Ensure consistent link underline and color on hover

[m158261]

References

This references Text Issue Area # 2 in #9399

This is a more up to date implementation of #14914

Code changes

Changes to CSS to make links more consistent throughout the application. Added new global CSS variables to light and dark themes.

User-facing changes

Links will have consistent colour and underline on hover therefore improving accessibility.

Current dark theme link

Updated dark theme link

Current hover over in dark theme

Updated hover over in dark theme

Current light theme link

Updated light theme link

Current hover over in light theme

Updated hover over in light theme

Backwards-incompatible changes

None

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[m158261]

Hey @krassowski, I'm getting test failures in galata but different tests are failing each time. Is there anything I can do to make the UI tests more stable for this PR?

[krassowski]

Thank you @m158261. I restated the tests again and hope these will pass now.

if needed we can adjust specific colours later easily thanks to the new variables.

[fcollonval]

Thanks @m158261

I'll push a commit that adds the previous variable as fallback to support existing themes not defining the new variables.

Similar to what was done in #11264

[krassowski]

@m158261 just FYI, I would have merged it now but I cannot because the CI is running after you merged the main branch in:

I appreciate the effort to ensure the changes are still neatly working with the latest HEAD but when folks do that on a number of PRs we simply run out of CI time (there is a number on concurrent jobs we get as open source project) and it sometimes slows down the process.

Not a big problem, just something for you to consider how often you do the merges, especially when the PR is waiting for review when we see a recent activity it may be wrongly interpreted as "still in progress" and makes the maintainer think "I will come back once CI finishes to check the status".

[m158261]

@m158261 just FYI, I would have merged it now but I cannot because the CI is running after you merged the main branch in:

I appreciate the effort to ensure the changes are still neatly working with the latest HEAD but when folks do that on a number of PRs we simply run out of CI time (there is a number on concurrent jobs we get as open source project) and it sometimes slows down the process.

Not a big problem, just something for you to consider how often you do the merges, especially when the PR is waiting for review when we see a recent activity it may be wrongly interpreted as "still in progress" and makes the maintainer think "I will come back once CI finishes to check the status".

@krassowski Sorry! Force of habit. I'll make sure to only merge when necessary in future.

[tonyfast]

psyched this is merged. this is a win. thanks y'all!