Fix completer tests after transition to pointer events #15237
Merged
+46
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
This was referenced Oct 8, 2023
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Oct 9, 2023
… pointer events
|
@krassowski you set the target to 3.6.x is it to backport the polyfill only as the mentioned PR has not been backported to 3.6.x? |
|
I set it to 3.6.x because #14534 was a bug fix to an issue in 3.6.x (but I did not backport it yet so indeed for now there is no need to backport this one either). Edit: I will clean up backports in the evening. |
|
I added the tag Still needs manual backport to not forget about this. |
krassowski
added a commit
that referenced
this pull request
Oct 9, 2023
…vents (#15243) Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
krassowski
added a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Oct 9, 2023
… pointer events Cherry-picked from commit 206368a.
krassowski
added a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Oct 9, 2023
… pointer events Cherry-picked from commit 206368a.
krassowski
added a commit
that referenced
this pull request
Oct 18, 2023
… changing notebook tabs) (#15244) * Backport PR #14534: Hide completer when changing notebook tabs * Backport PR #15237: Fix completer tests after transition to pointer events Cherry-picked from commit 206368a. --------- Co-authored-by: Nishikant Parmar <nishikantparmar123@gmail.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Follow-up after #14534
Code changes
mousedowntopointerdownpointerdownto@jupyterlab/testingUser-facing changes
None
Backwards-incompatible changes
None