Add defaultPath option to set the default directory for file dialog
#15282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
mmichilot
changed the title
krassowski
reviewed
Oct 20, 2023
There was a floating promise in createFilteredFileBrowser as a result of calling model.cd(). To fix the floating promise, createdFilteredFileBrowser is async and respective changes propagated to places it was used.
|
CI failures are not related |
mmichilot
commented
Oct 25, 2023
krassowski
reviewed
Oct 28, 2023
|
Congrats on your first merged pull request in this project! 🎉 |
krassowski
changed the title
defaultPath option to set the default directory for file dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the duplicate pull request, decided to move changes into a separate branch
References
Adds the defaultPath option referenced in #12929
Code changes
Adds a new optional
defaultPathoption toIDirectoryOptions. This option is then passed tocreateFilteredFileBrowserwhere it usesdefaultPathto change the directory of the model. The resulting file dialog opens to the given path instead of root.Also added two new tests to verify
defaultPathfunctionality.Within a folder in root, a new file and folder are added as shown:
The tests check that the parent directory of the selected file/folder matches the given
defaultPath.User-facing changes
None
Backwards-incompatible changes
None
Additional Question(s)
There is a lint error regarding floating promises. Since
model.cd()returnsPromise<void>and doesn't throw an error, would it be safe to mark the call as intentionally not awaited using the void operator?