Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement level trait for plugin/extension managers #15512

Merged

Conversation

krassowski
Copy link
Member

References

Fixes #15486

Code changes

  • adds level trait for plugin manager (and extension manager by inheritance) which matches the level trait of jupyter labextension sub-commands.
  • do not collect tests from .ipynb_checkpoints.

User-facing changes

The new trait can be set from CLI (or config file), for example:

jupyter lab --PluginManager.level user  # this has effect on both plugin and extension manager

or:

jupyter lab --PyPIExtensionManager.level user  # this only has an effect on extension manager

Backwards-incompatible changes

None

Verified

This commit was signed with the committer’s verified signature.
isaacs isaacs
This matches the `level` CLI option for `labextension` command.

Also do not collect tests from `.ipynb_checkpoints`.
@krassowski krassowski added the bug label Dec 11, 2023
@krassowski krassowski added this to the 4.1.0 milestone Dec 11, 2023
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski krassowski marked this pull request as ready for review December 11, 2023 01:30
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski

@krassowski krassowski merged commit 77cc55e into jupyterlab:main Dec 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin manager doesn't allow users to enable an extension
3 participants