Fix kernel shortcuts, add migration, fix defaults population #15639
Conversation
|
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Thanks @krassowski, I only have some comments below, otherwise it looks good to me.
| ); | ||
| } | ||
|
|
||
| return result; | ||
| } else if (schema.type === 'array') { | ||
| const defaultUndefined = typeof schema.default !== 'undefined'; |
There was a problem hiding this comment.
For consistency, shouldn't it be defaultDefined ?
There was a problem hiding this comment.
Absolutely, good catch - thanks!
| console.warn( | ||
| 'Deprecated shortcut selectors: ' + | ||
| [...selectorDeprecationWarnings].concat('\n') + | ||
| '\n\nThe selectors will be substituted transparently this time, but need to be updated at source before next major release.' | ||
| ); |
There was a problem hiding this comment.
It should be nice to have a way to warn only once, when all the plugins are loaded.
This is not for this PR, but having a way to concatenate all messages from plugin loading should be nice, to avoid duplication.
For example, if we restore only one selector from plugin.json, we receive 16 warnings in the console.
There was a problem hiding this comment.
Indeed. We could use some global variable in Private to de-duplicate; let me take a look.
krassowski
force-pushed
the
fix-kernel-shortcuts
branch
from
c02e34c
to
ba0efa8
Compare
|
Thanks @krassowski |
References
Code changes
winKeys,linuxKeysandmacKeysincorrectly popping up in defaults and leading to corruption of shortcuts, which fixes configuring shortcuts and user shortcuts being incorrectly populatedUser-facing changes
JSON setting editor defaults now show up correctly
Shortcuts (optional linux/mac/win keys no longer incorrectly shown as objects)
Context menu
HTML sanitizer
Backwards-incompatible changes
None