-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kernels sidepanel scrollbar #15718
Merged
krassowski
merged 17 commits into
jupyterlab:main
from
FoSuCloud:fix-kernels-sidepanel-scrollbar
Jan 31, 2024
Merged
Fix kernels sidepanel scrollbar #15718
krassowski
merged 17 commits into
jupyterlab:main
from
FoSuCloud:fix-kernels-sidepanel-scrollbar
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in non-English language
Thanks for making a pull request to jupyterlab! |
github-actions
bot
added
pkg:running
tag:CSS
For general CSS related issues and pecadilloes
Design System CSS
labels
Jan 31, 2024
@meeseeksdev tag bug |
krassowski
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @FoSuCloud! I can confirm that this fixes the issue.
Merging - the failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #15705
Code changes
cancel
.jp-RunningSessions-sectionContainer
cssoverflow:auto
Because
.jp-RunningSessions-section
also hasoverflow:auto
User-facing changes
Before the change, there would be two scroll bars when scrolling, and it was difficult to scroll to the end.
After the change, only one scrollbar exists
Backwards-incompatible changes
nothing