Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kernels sidepanel scrollbar #15718

Merged
merged 17 commits into from
Jan 31, 2024

Conversation

FoSuCloud
Copy link
Contributor

References

Fixes #15705

Code changes

cancel .jp-RunningSessions-sectionContainer css overflow:auto
Because .jp-RunningSessions-section also has overflow:auto
截屏2024-01-31 09 12 44

User-facing changes

Before the change, there would be two scroll bars when scrolling, and it was difficult to scroll to the end.
截屏2024-01-31 09 24 50

After the change, only one scrollbar exists
截屏2024-01-31 09 20 08

Backwards-incompatible changes

nothing

Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added pkg:running tag:CSS For general CSS related issues and pecadilloes Design System CSS labels Jan 31, 2024
@FoSuCloud
Copy link
Contributor Author

@meeseeksdev tag bug

@lumberbot-app lumberbot-app bot added the bug label Jan 31, 2024
@krassowski krassowski added this to the 4.1.0 milestone Jan 31, 2024
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @FoSuCloud! I can confirm that this fixes the issue.

@krassowski
Copy link
Member

Merging - the failing Paste Cell test is unrelated (tracked in #15719).

@krassowski krassowski merged commit 6554eea into jupyterlab:main Jan 31, 2024
76 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Design System CSS pkg:running tag:CSS For general CSS related issues and pecadilloes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running Terminals and Kernels sidepanel scrollbar issue
2 participants