Fix running kernels listing for kernels without icons

[paolocarinci]

References

Issue #14962

Code changes

This patch prevents a crash in running kernels panel jupyterlab component (packages/running) in case of use of kernels that do not provide an icon (like "all the kernels" kernel).

User-facing changes

Kernels tha do not provide an icon should be visible as text only.

Backwards-incompatible changes

None

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[krassowski]

Thank you @paolocarinci, this looks good to me.

Normally we would want to add a test for the bug being addressed, but since running packages does not have tests set up that would be a big ask for a first PR. However, if you are interested let me know and I can guide you how to add tests (potentially in a follow-up PR).

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

[krassowski]

@meeseeksdev please backport to 4.0.x

[paolocarinci]

Thank you for accepting my pull request @krassowski. I would glad to help improving Jupyterlab by writing test code for the running frontend package, so please let me know how I can write unit tests. I can't ensure you I will manage to do it quickly, but I'll do my best to write at least the three test cases for the icon management reasonably soon and make a follow-up pull request. Il Sab 3 Feb 2024, 18:59 Michał Krassowski ***@***.***> ha scritto:

…

***@***.**** approved this pull request. Thank you @paolocarinci <https://github.com/paolocarinci>, this looks good to me. Normally we would want to add a test for the bug being addressed, but since running packages does not have tests set up that would be a big ask for a first PR. However, if you are interested let me know and I can guide you how to add tests (potentially in a follow-up PR). — Reply to this email directly, view it on GitHub <#15735 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXUJTIGLY6OMAA4Q722QCSTYRZ3HTAVCNFSM6AAAAABCXKN54OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNRRGA4TSNRZGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>