400% zoom low vision #15855
400% zoom low vision #15855
Conversation
…15/jupyterlab into low-vision-support-10004-version-2
|
Thanks for making a pull request to jupyterlab! |
github-actions
bot
added
pkg:filebrowser
pkg:application
tag:CSS
|
The only way I see forward on this PR is breaking it up into several individual PRs where we change one and only one CSS style rule at a time. This may sound like a contradiction of something I said in a previous meeting about not opening, closing, and duplicating PRs. However, this PR is a unique situation. We're really struggling to figure out what's causing some of the snapshots to fail, so I think unfortunately, the best path forward is to break these changes up and handle them one at a time. |
|
One other thing. I think we need to establish a point of view about when zoom-related changes should start to kick in. For example the selector |
Isolated Code changes and their effects on Screenshots |
|
Right. But those PRs are each against a fork of jupyterlab rather than jupyterlab/jupyterlab. I was thinking that we should open the isolated changes as PRs against the jupyterlab/jupyterlab repo, and I'm hoping that handling them one at a time will make it easier to review them and get them in. As far as I can tell, there's no reason that all the CSS changes in this PR need to be merged together. |
|
I'd be happy to do the work to break up the PR into separate PRs, but I don't know how to do that without using my own Git commits, which would change who the changes get attributed to, so I don't want to do that without asking your permission first. |
|
Happy for you to break up the PR into separate PRs |
|
Should we close this PR in favour of #14766 or the other way? Why are there so many PRs?
The number of PRs opened and number of spurious commits has really drained my maintenance energy. |
References
#14626
#14766
#10004 This PR covers Full low Vision Support (400% Zoom) (Mobile/Tablet-Responsive Support).
It resolves most of the failing screenshots that where present in #14766. The approach used was to isolate each code change in the previous PR to see what/ If the code changes are breaking screenshots.
Isolated Code changes and their effects on Screenshots
Code changes
Changed padding and spacing to use min CSS function alongside vh (viewport-height) and vw(viewport-width) to reduce proportional spacing at high zoom and increase useful screen real estate usage.
User-facing changes
Currently with the 400% zoom at 1280px the help main menu bar does not appear and within the file-browser tab bar only half of one 'dir-listing' shows up.
The changes I have made now allows for the help dropdown to be shown in the main menu. I found that when trying to check the changes the sidebar 'Extension Manger' disappears from view, so this was also changes so that users that needs this implemented would be able to have access to it without zooming back out.
Furthermore, within the file-browser tab, users would now be able to see least 2 notebook directory listed below than before.
Backwards-incompatible changes