New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra non-critical revisions for the dual compatibility document #15866
base: main
Are you sure you want to change the base?
Extra non-critical revisions for the dual compatibility document #15866
Conversation
…yterlab into dual_compat_extensions
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
for more information, see https://pre-commit.ci
…yterlab into dual_compat_extensions
for more information, see https://pre-commit.ci
…yterlab into dual_compat_extensions
for more information, see https://pre-commit.ci
…yterlab into dual_compat_extensions
for more information, see https://pre-commit.ci
Update code snippets Improve text format for RST
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Thanks for making a pull request to jupyterlab! |
FYI, resolving reviewers comments is the best way to expedite PR being merged ;) |
I thought this struck a good balance between serving our users (by delivering a version to them), capturing the work remaining to be done (which will need to be done over multiple PRs) and acknowledging the work already done on the 5-6 PRs that make up the first compatibility doc's workstreams, though I take your point 👍 |
@ericsnekbytes could you resolve conflicts here (and ideally cleanup the history) (if this is still needed). |
Will do, I'll comb over and itemize/list any remaining work in the top comment 👍 |
@ericsnekbytes just checking back here? |
@krassowski On the surface, it seems like you resolved all of the open items in the previous PR, but I wanted to do a detailed review to ensure I didn't miss anything. Once that's done, I'll close this PR if needed. |
@ericsnekbytes just a remainder on this one :) |
@krassowski These are the remaining items I found while checking the original PR, if you have any to add feel free. I had problems using sphinx references last time, so those will likely take some troubleshooting to fix. |
This PR splits out some extra suggestions from the compatibility document PR (link below). Once that PR is merged and in users hands, we can do some additional edits here (some of the code changes will require commits here AND in the examples repo, so it makes sense to do these separately to expedite the original PR which has been waiting for approval for a long time now):