Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra non-critical revisions for the dual compatibility document #15866

Draft
wants to merge 59 commits into
base: main
Choose a base branch
from

Conversation

ericsnekbytes
Copy link
Contributor

@ericsnekbytes ericsnekbytes commented Feb 23, 2024

This PR splits out some extra suggestions from the compatibility document PR (link below). Once that PR is merged and in users hands, we can do some additional edits here (some of the code changes will require commits here AND in the examples repo, so it makes sense to do these separately to expedite the original PR which has been waiting for approval for a long time now):

ericsnekbytes and others added 30 commits July 17, 2023 11:07
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski krassowski changed the title Extra non-critical revisions for the dual copatibility document Extra non-critical revisions for the dual compatibility document Feb 23, 2024
@krassowski
Copy link
Member

some of the code changes will require commits here AND in the examples repo, so it makes sense to do these separately to expedite the original PR

FYI, resolving reviewers comments is the best way to expedite PR being merged ;)

@ericsnekbytes
Copy link
Contributor Author

some of the code changes will require commits here AND in the examples repo, so it makes sense to do these separately to expedite the original PR

FYI, resolving reviewers comments is the best way to expedite PR being merged ;)

I thought this struck a good balance between serving our users (by delivering a version to them), capturing the work remaining to be done (which will need to be done over multiple PRs) and acknowledging the work already done on the 5-6 PRs that make up the first compatibility doc's workstreams, though I take your point 👍

@krassowski
Copy link
Member

krassowski commented Mar 5, 2024

@ericsnekbytes could you resolve conflicts here (and ideally cleanup the history) (if this is still needed).

@ericsnekbytes
Copy link
Contributor Author

@ericsnekbytes could you resolve conflicts here (and ideally cleanup the history) (if this is still needed).

Will do, I'll comb over and itemize/list any remaining work in the top comment 👍

@krassowski
Copy link
Member

@ericsnekbytes just checking back here?

@ericsnekbytes
Copy link
Contributor Author

@krassowski On the surface, it seems like you resolved all of the open items in the previous PR, but I wanted to do a detailed review to ensure I didn't miss anything. Once that's done, I'll close this PR if needed.

@krassowski
Copy link
Member

@ericsnekbytes just a remainder on this one :)

@ericsnekbytes
Copy link
Contributor Author

ericsnekbytes commented Apr 17, 2024

I'm assembling a list of items to address in this PR below:

  • Use sphinx references instead of fully qualified links as noted here and here
  • Check the examples repo to ensure code matches the edits made

@ericsnekbytes
Copy link
Contributor Author

@krassowski These are the remaining items I found while checking the original PR, if you have any to add feel free. I had problems using sphinx references last time, so those will likely take some troubleshooting to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants