Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid explicit any, migrate to unknown or proper typing #16219

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Forbid explicit any, migrate to unknown or proper typing #16219

wants to merge 8 commits into from

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Apr 22, 2024 •
edited

References

#16038

Code changes

Forbids any, except in variadics.

The intent is to:

  • keep any in core APIs to avoid disruption (just add eslint-disable comments as needed)
  • use unknown in leaf APIs and in function bodies where we can be fairly certain it will not cause disruption

TODO:

  • this PR and this rule should not apply to test files to reduce the diff and because we worry less about typing in tests

User-facing changes

None

Backwards-incompatible changes

TBD

@jupyterlab-probot jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 22, 2024
View reviewed changes
packages/services/test/config/config.spec.ts Fixed Show fixed Hide fixed
buildutils/src/local-repository.ts Fixed Show fixed Hide fixed
buildutils/src/local-repository.ts Fixed Show fixed Hide fixed
buildutils/src/local-repository.ts Fixed Show fixed Hide fixed
buildutils/src/local-repository.ts Fixed Show fixed Hide fixed
@krassowski krassowski added this to the 4.3.0 milestone Apr 22, 2024
krassowski
krassowski commented Apr 22, 2024
View reviewed changes
packages/services/examples/browser/src/index.ts
@@ -6,7 +6,7 @@
*/

import { PageConfig, URLExt } from '@jupyterlab/coreutils';
(window as any).__webpack_public_path__ = URLExt.join(
(window as unknown).__webpack_public_path__ = URLExt.join(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will need reverting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@krassowski krassowski

Labels
maintenance pkg:application pkg:apputils pkg:cells pkg:codeeditor pkg:codemirror pkg:completer pkg:console pkg:coreutils pkg:csvviewer pkg:debugger pkg:docmanager pkg:docregistry pkg:extensionmanager pkg:filebrowser pkg:fileeditor pkg:help pkg:hub pkg:imageviewer pkg:inspector pkg:launcher pkg:logconsole pkg:lsp pkg:mainmenu pkg:mathjax pkg:mermaid pkg:metadataform pkg:notebook pkg:observables pkg:outputarea pkg:pdf pkg:pluginmanager pkg:rendermime pkg:running pkg:services pkg:settingeditor pkg:settingregistry pkg:shortcuts pkg:statedb pkg:statusbar pkg:terminal pkg:toc pkg:tooltip pkg:translation pkg:ui-components pkg:vega pkg:workspaces tag:Examples tag:Testing
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@krassowski