-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shut down unused kernels #16341
base: main
Are you sure you want to change the base?
Shut down unused kernels #16341
Conversation
Thanks for making a pull request to jupyterlab! |
Thank you for working on this!
|
b7a9e55
to
4bc39a4
Compare
4bc39a4
to
0613d74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking better - leaving some more feedback on this iteration.
toolbarButtons: [ | ||
new CommandToolbarButton({ | ||
commands, | ||
id: SHUTDOWN_UNUSED_BUTTON_CLASS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a quick glance the logic looks all good now. The last thing I would suggest is using an icon instead of text for this button. Let's first choose and add an icon to the command. I think some kind of material design icon for cleaning could do?
id: SHUTDOWN_UNUSED_BUTTON_CLASS, | |
icon: someIcon, | |
id: SHUTDOWN_UNUSED_BUTTON_CLASS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added one, I don't see very many options for icons
I manually added it to /jupyterlab/packages/ui-components/src/icon/iconimports.ts
which needs to be fixed since it's supposed to be auto-generated
Should the text for Shut Down All
and Shut Down Unused
be removed, and just have icons instead, since there's not that much room
References
closes #13916
Code changes
Adds a button to Shut Down Unused kernels
User-facing changes
Backwards-incompatible changes