-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align token usage for events #16397
Merged
krassowski
merged 1 commit into
jupyterlab:main
from
fcollonval:fix/align-token-for-ws-events
May 31, 2024
Merged
Align token usage for events #16397
krassowski
merged 1 commit into
jupyterlab:main
from
fcollonval:fix/align-token-for-ws-events
May 31, 2024
+7
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for making a pull request to jupyterlab! |
minrk
approved these changes
May 30, 2024
krassowski
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The CI failure is unrelated (#16404) |
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
May 31, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
May 31, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
May 31, 2024
krassowski
pushed a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: Frédéric Collonval <frederic.collonval@webscit.com>
krassowski
pushed a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: Frédéric Collonval <frederic.collonval@webscit.com>
krassowski
pushed a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: Frédéric Collonval <frederic.collonval@webscit.com>
ImpSy
pushed a commit
to spotinst/jupyterlab
that referenced
this pull request
Jan 7, 2025
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Follow up question by @emrahyildiz
Code changes
Align token usage in events API calls.
User-facing changes
None
Backwards-incompatible changes
None