Fix some flaky ui tests #16430
Merged
Fix some flaky ui tests #16430
+21
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….pressSequentially()'
…, to be able to properly await it
|
Thanks for making a pull request to jupyterlab! |
krassowski
reviewed
Jun 4, 2024
krassowski
reviewed
Jun 4, 2024
Comment on lines
63
to
65
| .pressSequentially( | ||
| 'Not active\nActive line with >>selected text<<\nNot active' | ||
| ); |
There was a problem hiding this comment.
I would expect fill to work here. Does it not?
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
krassowski
approved these changes
Jun 6, 2024
|
Nice, thanks @brichet! |
|
@meeseeksdev please backport to 4.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jun 6, 2024
jtpio
pushed a commit
that referenced
this pull request
Jun 7, 2024
Co-authored-by: Nicolas Brichet <32258950+brichet@users.noreply.github.com>
ImpSy
pushed a commit
to spotinst/jupyterlab
that referenced
this pull request
Jan 7, 2025
* Replace deprecated 'Locator.press()' with 'Locator.fill()' or Locator.pressSequentially()' * Set 'docmanager:open' and 'docmanager:new-untitled' commands as async, to be able to properly await it * Use to fill the cell content, to avoid backward incompatibility * Update galata/test/jupyterlab/texteditor.test.ts Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> * Use preferably 'Locator.fill()' --------- Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR may fix some flaky UI tests.
Locator.type()withLocator.fill(), to try to fix some tests writing in the cell input.For example
test/jupyterlab/notebook-max-outputs.test.ts:37:5 › Don't limit cell outputs if input is requestedoften fails due to indentation error in cell input.In the screenshot above, the input should not be indented
'docmanager:open'asasync, according to VSCode warning "This may be converted to an async function.ts(80006)".Not sure to understand why, but it seems to fix (locally)
test/jupyterlab/settings.test.ts:129:7 › change font-size › should Increase Content Font Sizeandtest/jupyterlab/settings.test.ts:129:7 › change font-size › should Decrease Content Font Size, which also often fails withe the following error:References
related to #14947
Code changes
None
User-facing changes
None
Backwards-incompatible changes
None