Fix typos in jupyter-collaboration-missing error message
#16436
Conversation
|
Thanks for making a pull request to jupyterlab! |
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
| To fix this, either: | ||
| 1) install the extension `jupyter_collaboration`; for example: `python -m pip install jupyter_collaboration` | ||
| 1) install the extension `jupyter-collaboration`; for example: `python -m pip install jupyter-collaboration` |
There was a problem hiding this comment.
👍 indeed, this is preferred. pip does not care, but conda does not normalize, and the feedstock uses - over _ (https://github.com/conda-forge/jupyter-collaboration-feedstock)
There was a problem hiding this comment.
yes sorry! I copy-pasted into conda and had it fail which is why I opened this PR
In future you can ask the bot to do so like: @meeseeksdev tag bug |
|
Congrats on your first merged pull request in this project! 🎉 |
|
@meeseeksdev please backport to 4.2.x |
…ssing error message
…r message (#16440) Co-authored-by: Krishan Bhasin <164889026+krishanbhasin-px@users.noreply.github.com>
References
N/A
Code changes
Update the content of the
log.criticalmessage aboutjupyter-collaborationbeing missingUser-facing changes
Jupyteris spelled correctlyjupyter-collaborationcan now be copy-pasted by users to fix the issue (prior usage ofjupyter_collaborationwas different to the conda and pip package names)Backwards-incompatible changes
N/A
Notes
CI is failing with
but I lack the permissions to do so