Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'New Folder' item to filebrowser context menu #5447

Merged
merged 1 commit into from Oct 13, 2018

Conversation

reevejd
Copy link
Member

@reevejd reevejd commented Oct 6, 2018

Adds a “New Folder” item to the file browser context menu (addresses half of #4280).

screen shot 2018-10-06 at 1 07 50 am

screen shot 2018-10-06 at 1 08 04 am

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073
Copy link
Member

@reevejd, it looks like we've picked up a merge conflict. I would have made the change myself, but this is your master branch. Mind rebasing?

@reevejd
Copy link
Member Author

reevejd commented Oct 6, 2018

@blink1073 done

@ian-r-rose
Copy link
Member

Thanks for being flexible as we work on the kinks in this new filebrowser context menu @reevejd!

@blink1073 blink1073 merged commit 21312b2 into jupyterlab:master Oct 13, 2018
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement pkg:filebrowser status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants