Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ctrl-f/g support for notebooks and text files #5795

Merged
merged 46 commits into from Feb 1, 2019
Merged

Add ctrl-f/g support for notebooks and text files #5795

merged 46 commits into from Feb 1, 2019

Commits on Jan 7, 2019

  1. wip

    @aschlaep
    aschlaep committed Jan 7, 2019
    Copy the full SHA
    48a8fed View commit details
    Browse the repository at this point in the history

  2. remove files

    @aschlaep
    aschlaep committed Jan 7, 2019
    Copy the full SHA
    a1a84d2 View commit details
    Browse the repository at this point in the history

  3. partially implemented search

    @aschlaep
    aschlaep committed Jan 7, 2019
    Copy the full SHA
    891ae5d View commit details
    Browse the repository at this point in the history

  4. forward and reverse search mostly works

    @aschlaep
    aschlaep committed Jan 7, 2019
    Copy the full SHA
    142166c View commit details
    Browse the repository at this point in the history

  5. improved search, need to reexamine indexing

    @aschlaep
    aschlaep committed Jan 7, 2019
    Copy the full SHA
    d9408ea View commit details
    Browse the repository at this point in the history

  6. mostly working, needs cleanup

    @aschlaep
    aschlaep committed Jan 7, 2019
    Copy the full SHA
    01804c0 View commit details
    Browse the repository at this point in the history

  7. wip: mainly feature complete, needs testing, UI, code cleanup

    @aschlaep
    aschlaep committed Jan 7, 2019
    Copy the full SHA
    8aea812 View commit details
    Browse the repository at this point in the history

  8. live update index

    @aschlaep
    aschlaep committed Jan 7, 2019
    Copy the full SHA
    7d3989e View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2019

  1. new UI, styling

    @aschlaep
    aschlaep committed Jan 12, 2019
    Copy the full SHA
    4f746d0 View commit details
    Browse the repository at this point in the history

  2. minor cleanup

    @aschlaep
    aschlaep committed Jan 12, 2019
    Copy the full SHA
    d94d150 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. styling updates, small bugfixes

    @aschlaep
    aschlaep committed Jan 16, 2019
    Copy the full SHA
    544ae5e View commit details
    Browse the repository at this point in the history

  2. remove lastquery, change command category

    @aschlaep
    aschlaep committed Jan 16, 2019
    Copy the full SHA
    bf0ccbd View commit details
    Browse the repository at this point in the history

  3. manual initial codemirror scan to avoid issue with lazy loading searc… 

    …h overlay
    @aschlaep
    aschlaep committed Jan 16, 2019
    Copy the full SHA
    181bd04 View commit details
    Browse the repository at this point in the history

  4. code review updates

    @aschlaep
    aschlaep committed Jan 16, 2019
    Copy the full SHA
    4d978f1 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. cleanup, comments

    @aschlaep
    aschlaep committed Jan 17, 2019
    Copy the full SHA
    667a4e9 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2019

  1. guard against non-searchable widgets, update overlay toggle logic

    @aschlaep
    aschlaep committed Jan 28, 2019
    Copy the full SHA
    744cefd View commit details
    Browse the repository at this point in the history

  2. cleanup per review

    @aschlaep
    aschlaep committed Jan 28, 2019
    Copy the full SHA
    58a81f9 View commit details
    Browse the repository at this point in the history

  3. add styling, resources

    @aschlaep
    aschlaep committed Jan 28, 2019
    Copy the full SHA
    42f4d73 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. changes per jasons comments

    @aschlaep
    aschlaep committed Jan 29, 2019
    Copy the full SHA
    14a318e View commit details
    Browse the repository at this point in the history

  2. Change search registry to use a Map.

    @jasongrout
    jasongrout committed Jan 29, 2019
    Copy the full SHA
    525b1a8 View commit details
    Browse the repository at this point in the history

  3. move canSearchOn to static

    @aschlaep
    aschlaep committed Jan 29, 2019
    Copy the full SHA
    272af34 View commit details
    Browse the repository at this point in the history

  4. update licenses

    @aschlaep
    aschlaep committed Jan 29, 2019
    Copy the full SHA
    ad1396f View commit details
    Browse the repository at this point in the history

  5. private underscores

    @aschlaep
    aschlaep committed Jan 29, 2019
    Copy the full SHA
    d76f1a8 View commit details
    Browse the repository at this point in the history

  6. Simplify search provider registry find function.

    @jasongrout
    jasongrout committed Jan 29, 2019
    Copy the full SHA
    5f206c3 View commit details
    Browse the repository at this point in the history

  7. bind -> arrow functions

    @jasongrout
    jasongrout committed Jan 29, 2019
    Copy the full SHA
    e4ed607 View commit details
    Browse the repository at this point in the history

  8. Change the functions to take only widgets instead of shell. 

    Also update to JLab conventions (add docstrings, underscore private things, async/await)
    @jasongrout
    jasongrout committed Jan 29, 2019
    Copy the full SHA
    b1d95bb View commit details
    Browse the repository at this point in the history

  9. Formatting

    @jasongrout
    jasongrout committed Jan 29, 2019
    Copy the full SHA
    7b3bef3 View commit details
    Browse the repository at this point in the history

  10. Change signal to have a ‘this’ sender, move offset to SearchInstance 

    A few other cleanup changes.
    @jasongrout
    jasongrout committed Jan 29, 2019
    Copy the full SHA
    184074e View commit details
    Browse the repository at this point in the history

  11. Move initializing steps into constructor.

    @jasongrout
    jasongrout committed Jan 29, 2019
    Copy the full SHA
    d75e5c5 View commit details
    Browse the repository at this point in the history

  12. Break SearchInstance into its own file

    @aschlaep
    aschlaep committed Jan 29, 2019
    Copy the full SHA
    d5ac6fb View commit details
    Browse the repository at this point in the history

  13. Make SearchInstance implement IDisposable

    @aschlaep
    aschlaep committed Jan 29, 2019
    Copy the full SHA
    fb7f998 View commit details
    Browse the repository at this point in the history

  14. async await SearchInstance

    @aschlaep
    aschlaep committed Jan 29, 2019
    Copy the full SHA
    53aea0f View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. switch to async/await in NBSearchProvider, fix off by one issues

    @aschlaep
    aschlaep committed Jan 30, 2019
    Copy the full SHA
    046c830 View commit details
    Browse the repository at this point in the history

  2. async await, update license, and minor refactor for CMSearchProvier, … 

    …update CSS, cleanup imports
    @aschlaep
    aschlaep committed Jan 30, 2019
    Copy the full SHA
    3478507 View commit details
    Browse the repository at this point in the history

  3. remove private namespace in NBSearchProvider

    @aschlaep
    aschlaep committed Jan 30, 2019
    Copy the full SHA
    9a0b5dc View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2019

  1. escape to close, address focus issue, add docs to searchproviders

    @aschlaep
    aschlaep committed Jan 31, 2019
    Copy the full SHA
    38224e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pr/aschlaep/5795

    @jasongrout
    jasongrout committed Jan 31, 2019
    Copy the full SHA
    f052f5c View commit details
    Browse the repository at this point in the history

  3. Fix the search extension to use the new frontend objects.

    @jasongrout
    jasongrout committed Jan 31, 2019
    Copy the full SHA
    9e9eab5 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. switch to start/endQuery and endSearch, made search lifetime tweaks, … 

    …fixed small bugs
    @aschlaep
    aschlaep committed Feb 1, 2019
    Copy the full SHA
    6955cb0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ctrl-f-init' of github.com:aschlaep/jupyterlab into ctr… 

    …l-f-init
    @aschlaep
    aschlaep committed Feb 1, 2019
    Copy the full SHA
    0d048a5 View commit details
    Browse the repository at this point in the history

  3. fix toggle styling, fix bug on deleted md cell containing match

    @aschlaep
    aschlaep committed Feb 1, 2019
    Copy the full SHA
    52c75fb View commit details
    Browse the repository at this point in the history

  4. Take care of a few more lifecycle and enabling issues; add commands t… 

    …o menu.

Also, I refactored the code a bit, which ended up moving logic into the actual command execute functions.

Now find next and previous are only enabled when there is an active search open.
    @jasongrout
    jasongrout committed Feb 1, 2019
    Copy the full SHA
    de093b1 View commit details
    Browse the repository at this point in the history

  5. A bit more cleanup.

    @jasongrout
    jasongrout committed Feb 1, 2019
    Copy the full SHA
    337a628 View commit details
    Browse the repository at this point in the history

  6. Fix dependencies.

    @jasongrout
    jasongrout committed Feb 1, 2019
    Copy the full SHA
    8bef9a2 View commit details
    Browse the repository at this point in the history

  7. Fix codemirror typings for editor test.

    @jasongrout
    jasongrout committed Feb 1, 2019
    Copy the full SHA
    ea774b3 View commit details
    Browse the repository at this point in the history

  8. Fix lint error.

    @jasongrout
    jasongrout committed Feb 1, 2019
    Copy the full SHA
    31e0484 View commit details
    Browse the repository at this point in the history