Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for printing widgets #5850
Add support for printing widgets #5850
Changes from 32 commits
ef8213e
a788ee7
ecf0a10
00349dc
c58e78c
1b01f68
e441c50
7838425
6f6b967
1da3604
aa8e557
07fb2ed
3a77854
67dbe5d
8ad8972
13c63ae
cbc43d9
4cd02f0
3f93b58
fe033cc
0c65a50
45d181b
b5b2527
c4240cd
e442930
61e978f
5e415dc
58dbb5b
3be993e
80b3d5e
055f59a
310a272
3c9aadd
959268f
2f9f672
3bfc916
8c7ea4c
8703549
1593668
d225704
ca9890d
a406241
609799b
77cb8da
208aa83
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could use the
IFrame
widget here. Not necessary, but worth thinking about.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to wait for the
load
event? My experience with the PDF viewer is that it was necessary, but maybe that's not the case here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found we needed to wait.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afshin Can you comment on how this would relate to your recent work with
JupyterFrontEnd.IPaths
andPageConfig
? What would be the preferred way for a notebook widget to get a handle on the NBConvert URL?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping @afshin on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. I think we could probably get this working for PDFs as well.