Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update milestone check script #5938

Merged
merged 5 commits into from Feb 4, 2019
Merged

Update milestone check script #5938

merged 5 commits into from Feb 4, 2019

Conversation

jasongrout
Copy link
Contributor

This script is used in the release process to check that the milestone correctly reflects what is in the commit history.

WIP since there still needs to be some special-casing for PRs with more than 250 commits (such as #5508).

@jasongrout jasongrout added this to the 1.0 milestone Feb 2, 2019
@jasongrout
Fix milestone check script to paginate through large result sets.
62e5cc3 
We still cannot retrieve more than 250 commits for a PR, so exceptionally large PRs such as jupyterlab#5508 will still need some special-casing.
@jasongrout
Note some new PRs in the changelog that weren’t originally in the 1.0…
942f79d 
… milestone.
@jasongrout
Copy link
Contributor Author

jasongrout commented Feb 2, 2019 •
edited

More PRs to check that may need to be moved to the 1.0 milestone:

c0a8595 Merge pull request #5596 from skurt23/input-styling
ac2a1d8 Merge pull request #5679 from saulshanabrook/azure-pipelines
05b952b Merge pull request #5668 from fcollonval/remove-commands-in-filebrowser
d766470 Merge pull request #5512 from jtpio/new-text-file-palette
dc126c3 Merge pull request #5645 from johnkmzhou/autosave-interval
39c1c68 Merge pull request #5638 from joker2600/origin/issue-4866
4efe8c7 Merge pull request #5682 from gnestor/issue-2399
f0dfbf6 Merge pull request #5534 from melsyt/master
3d1f98c Merge pull request #5900 from jupyterlab/ellisonbg-patch-1
bf808f8 Merge pull request #5715 from kaylangan/patch-1
1256377 Merge pull request #5518 from blink1073/fix-override-url
9fa8616 Merge pull request #5642 from JohnJohnsonIII/master
86a2ddd Merge pull request #5833 from yuvipanda/better-notebook-example
63090ad Merge pull request #5772 from gavinhenderson/master
ffe8681 Merge pull request #5891 from yuvipanda/split-files
0f509a1 Merge pull request #5610 from jupyterlab/fix-svg-in-html
6004961 Merge pull request #5721 from lheagy/cursor-drag-drop
9e98064 Merge pull request #5742 from quigleyj97/feature/fix-docs-screenshot
bd47dbd Merge pull request #5647 from russtoku/issue-2346
cbe124d Merge pull request #5570 from AlbertHilb/TerminalSettings
41954f2 Merge pull request #5564 from payne92/pr_dev
c372251 Merge pull request #5906 from ntdef/issues-5899
1593760 Merge pull request #5677 from ian-r-rose/doc_links
67bf75c Merge pull request #5556 from commandlinegirl/fix_typo_in_css_rst
208fa74 Merge pull request #5898 from telamonian/large-font-theme-vars
f83c6da Merge pull request #5639 from powersparks/master
8c69a97 Merge pull request #5836 from yuvipanda/mathjax-charset
5264db5 Merge pull request #5722 from gnestor/analyze-bundle

@jasongrout
Copy link
Contributor Author

More PRs added:

Option to create new markdown file from Launcher and File > New #5511

@jasongrout
Copy link
Contributor Author

jasongrout commented Feb 2, 2019 •
edited

Okay, I think I cleaned up the PRs. Some PRs I had to unset from the 1.0 milestone and then set them again, which was weird. Current script output is:

WARNING: PR 5508 (merge d158501) has 410 commits, but GitHub is only giving us 250 of them
Milestone: 1.0, 154 merged PRs, 848 commits in history

Congratulations! All PRs in this milestone have commits in the commit history for this version range, so they all probably belong in this milestone.

The following commits are not included in any PR on this milestone.
This probably means the commit's PR needs to be assigned to this milestone,
or the commit was pushed to master directly.

be6b55d <email> back to dev version
5ff2562 noreply@github.com Use jupyter theme by default in

@jasongrout
Copy link
Contributor Author

More PRs to investigate adding to the changelog:

#5643
#5750
#5590
#5640

@jasongrout jasongrout changed the title WIP Update milestone check script Update milestone check script Feb 4, 2019
ian-r-rose
ian-r-rose approved these changes Feb 4, 2019
View reviewed changes
scripts/milestone_check.py
query test($milestone: Int!) {
repository(owner:"jupyterlab" name:"jupyterlab") {
milestone(number:$milestone) {
query test($cursor: String) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, I didn't realize we were using the new graphql based github api!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a fun exploration.

@jasongrout jasongrout merged commit 633de3b into jupyterlab:master Feb 4, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ian-r-rose ian-r-rose ian-r-rose approved these changes

Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasongrout @ian-r-rose