Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node dependencies and a browser field to services for the ws and node-fetch packages #5945

Merged
merged 2 commits into from Feb 5, 2019
Merged

Add node dependencies and a browser field to services for the ws and node-fetch packages #5945

merged 2 commits into from Feb 5, 2019

Commits on Feb 5, 2019

  1. Add node dependencies and a browser field to services for the ws and … 

    …node-fetch packages

Webpack should ignore our import of the ws and node-fetch nodejs packages because of the browser field (see https://github.com/defunctzombie/package-browser-field-spec#ignore-a-module).

Fixes jupyterlab#5856
    @jasongrout
    jasongrout committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    a35219b View commit details
    Browse the repository at this point in the history

  2. integrity

    @jasongrout
    jasongrout committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    433e0de View commit details
    Browse the repository at this point in the history