New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular running extension #6002
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
Just to address this: I think this is a good thing! That being said, there is currently CI issues that are delaying review/merge of a bunch of PRs across the repo that we're working to fix. So don't lose heart over the delays :) |
@recamshak I think if you rebase on / merge master to resolve the merge conflicts, the CI can now complete, and people will have time to review :) |
To be fair, it's been months since they've had input from reviewers, and they've only had 24 hours to respond. |
Whichever one gets merged is a win. Since we haven't heard from @recamshak since Feb and I can work on this as much as I want this removes uncertainty for me. |
Yes, please, go ahead. And @recamshak, thanks for your work on this, sorry for the delays while we were focusing on 1.0 issues, and please let us know if you want to help with this moving forward. |
@Queuecumber @jasongrout Sorry for the late reply. @Queuecumber Thank you for you work on solving the merge issues! |
Closing, replaced by #6895 which preserves these commits and adds the merge commit to bring it up to the current codebase. |
Fixes #5728
I didn't know about the above issue and the related PR #4724 until I was ready to submit the PR. However #4724 is more ambitious and AFAIU it does not directly solve this issue. So maybe this PR is still relevant?
With this PR it should be easy to add a section in the running panel for any extension.