Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular running extension #6002

Closed
wants to merge 4 commits into from

Conversation

recamshak
Copy link
Contributor

Fixes #5728

I didn't know about the above issue and the related PR #4724 until I was ready to submit the PR. However #4724 is more ambitious and AFAIU it does not directly solve this issue. So maybe this PR is still relevant?

With this PR it should be easy to add a section in the running panel for any extension.

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@recamshak recamshak changed the title [WIP] Modular running extension Modular running extension Feb 19, 2019
@vidartf
Copy link
Member

vidartf commented Mar 21, 2019

Just to address this: I think this is a good thing! That being said, there is currently CI issues that are delaying review/merge of a bunch of PRs across the repo that we're working to fix. So don't lose heart over the delays :)

@vidartf
Copy link
Member

vidartf commented Jul 24, 2019

@recamshak I think if you rebase on / merge master to resolve the merge conflicts, the CI can now complete, and people will have time to review :)

@Queuecumber
Copy link
Contributor

@vidartf Since the author is unresponsive I took over this PR at #6895 please have a look there

@jasongrout
Copy link
Contributor

To be fair, it's been months since they've had input from reviewers, and they've only had 24 hours to respond.

@Queuecumber
Copy link
Contributor

Whichever one gets merged is a win. Since we haven't heard from @recamshak since Feb and I can work on this as much as I want this removes uncertainty for me.

@jasongrout
Copy link
Contributor

Since we haven't heard from @recamshak since Feb and I can work on this as much as I want this removes uncertainty for me.

Yes, please, go ahead. And @recamshak, thanks for your work on this, sorry for the delays while we were focusing on 1.0 issues, and please let us know if you want to help with this moving forward.

@jasongrout jasongrout self-assigned this Jul 31, 2019
@recamshak
Copy link
Contributor Author

@Queuecumber @jasongrout Sorry for the late reply. @Queuecumber Thank you for you work on solving the merge issues!

@jasongrout
Copy link
Contributor

Closing, replaced by #6895 which preserves these commits and adds the merge commit to bring it up to the current codebase.

@jasongrout jasongrout closed this Aug 2, 2019
@jasongrout jasongrout modified the milestones: 1.1, Reference Aug 2, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Sep 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make running extension support third-party sessions
5 participants