New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Render all markdown cells" command #6029
Changes from 8 commits
11823ea
fe9195c
7fe1921
ad086c6
b1074ec
74c5398
0f66b28
153e630
6a4a91b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,6 +92,8 @@ export namespace CommandIDs { | |
|
||
export const runAll = 'runmenu:run-all'; | ||
|
||
export const runAllMarkdown = 'runmenu:run-all-markdown'; | ||
|
||
export const restartAndRunAll = 'runmenu:restart-and-run-all'; | ||
|
||
export const runAbove = 'runmenu:run-above'; | ||
|
@@ -674,7 +676,6 @@ export function createRunMenu(app: JupyterFrontEnd, menu: RunMenu): void { | |
isEnabled: Private.delegateEnabled(app, menu.codeRunners, 'runAll'), | ||
execute: Private.delegateExecute(app, menu.codeRunners, 'runAll') | ||
}); | ||
|
||
commands.addCommand(CommandIDs.restartAndRunAll, { | ||
label: () => { | ||
const noun = Private.delegateLabel(app, menu.codeRunners, 'noun'); | ||
|
@@ -693,11 +694,13 @@ export function createRunMenu(app: JupyterFrontEnd, menu: RunMenu): void { | |
execute: Private.delegateExecute(app, menu.codeRunners, 'restartAndRunAll') | ||
}); | ||
|
||
const runAllGroup = [CommandIDs.runAll, CommandIDs.restartAndRunAll].map( | ||
command => { | ||
return { command }; | ||
} | ||
); | ||
const runAllGroup = [ | ||
CommandIDs.runAll, | ||
CommandIDs.restartAndRunAll, | ||
CommandIDs.runAllMarkdown | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line can be removed. |
||
].map(command => { | ||
return { command }; | ||
}); | ||
|
||
menu.addGroup([{ command: CommandIDs.run }], 0); | ||
menu.addGroup(runAllGroup, 999); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -119,6 +119,8 @@ namespace CommandIDs { | |
|
||
export const runAllBelow = 'notebook:run-all-below'; | ||
|
||
export const renderAllMarkdown = 'notebook:render-all-markdown'; | ||
|
||
export const toCode = 'notebook:change-cell-to-code'; | ||
|
||
export const toMarkdown = 'notebook:change-cell-to-markdown'; | ||
|
@@ -1037,6 +1039,17 @@ function addCommands( | |
); | ||
} | ||
}); | ||
commands.addCommand(CommandIDs.renderAllMarkdown, { | ||
label: 'Render All Markdown Cells', | ||
execute: args => { | ||
const current = getCurrent(args); | ||
if (current) { | ||
const { context, content } = current; | ||
return NotebookActions.renderAllMarkdown(content, context.session); | ||
} | ||
}, | ||
isEnabled | ||
}); | ||
commands.addCommand(CommandIDs.restart, { | ||
label: 'Restart Kernel…', | ||
execute: args => { | ||
|
@@ -1788,6 +1801,7 @@ function populatePalette( | |
CommandIDs.restartClear, | ||
CommandIDs.restartRunAll, | ||
CommandIDs.runAll, | ||
CommandIDs.renderAllMarkdown, | ||
CommandIDs.runAllAbove, | ||
CommandIDs.runAllBelow, | ||
CommandIDs.selectAll, | ||
|
@@ -2073,6 +2087,14 @@ function populateMenus( | |
} | ||
} as IRunMenu.ICodeRunner<NotebookPanel>); | ||
|
||
// Add a renderAllMarkdown group to the run menu. | ||
const renderAllMarkdown = [ | ||
CommandIDs.renderAllMarkdown, | ||
CommandIDs.run, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you remove |
||
CommandIDs.runInConsole | ||
].map(command => { | ||
return { command }; | ||
}); | ||
// Add a run+insert and run+don't advance group to the run menu. | ||
const runExtras = [ | ||
CommandIDs.runAndInsert, | ||
|
@@ -2132,6 +2154,7 @@ function populateMenus( | |
mainMenu.editMenu.addGroup(splitMergeGroup, 9); | ||
mainMenu.runMenu.addGroup(runExtras, 10); | ||
mainMenu.runMenu.addGroup(runAboveBelowGroup, 11); | ||
mainMenu.runMenu.addGroup(renderAllMarkdown, 12); | ||
|
||
// Add kernel information to the application help menu. | ||
mainMenu.helpMenu.kernelUsers.add({ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this ID should be here at all -- there is no
'runmenu:run-all-markdown'
command defined as far as I see.