Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose icon SVG to theme CSS #6034

Merged
merged 85 commits into from Aug 14, 2019
Merged

Commits on Aug 14, 2019

  1. Copy the full SHA
    7eab2e7 View commit details
    Browse the repository at this point in the history
  2. added svg typings

    telamonian committed Aug 14, 2019
    Copy the full SHA
    d499b7b View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    8e6151f View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    aab6485 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    856e7b6 View commit details
    Browse the repository at this point in the history
  6. All svg formatting is fixed and at parity with master

    Still need to expose the remaining non-theme svgs
    telamonian committed Aug 14, 2019
    Copy the full SHA
    fcd93aa View commit details
    Browse the repository at this point in the history
  7. progress

    telamonian committed Aug 14, 2019
    Copy the full SHA
    3dca6b0 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    6713dfe View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    91352f5 View commit details
    Browse the repository at this point in the history
  10. progress

    telamonian committed Aug 14, 2019
    Copy the full SHA
    593124e View commit details
    Browse the repository at this point in the history
  11. simplification

    telamonian committed Aug 14, 2019
    Copy the full SHA
    3e54380 View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    c11d151 View commit details
    Browse the repository at this point in the history
  13. Copy the full SHA
    9947194 View commit details
    Browse the repository at this point in the history
  14. progress

    telamonian committed Aug 14, 2019
    Copy the full SHA
    27182d1 View commit details
    Browse the repository at this point in the history
  15. Copy the full SHA
    69a6411 View commit details
    Browse the repository at this point in the history
  16. webpack cleanup

    telamonian committed Aug 14, 2019
    Copy the full SHA
    d8ea0e5 View commit details
    Browse the repository at this point in the history
  17. Copy the full SHA
    2572625 View commit details
    Browse the repository at this point in the history
  18. Copy the full SHA
    dfb777f View commit details
    Browse the repository at this point in the history
  19. delinted

    telamonian committed Aug 14, 2019
    Copy the full SHA
    429fbce View commit details
    Browse the repository at this point in the history
  20. Copy the full SHA
    d8d3cd3 View commit details
    Browse the repository at this point in the history
  21. Copy the full SHA
    58e0163 View commit details
    Browse the repository at this point in the history
  22. Copy the full SHA
    414ca89 View commit details
    Browse the repository at this point in the history
  23. Copy the full SHA
    ed3ddc0 View commit details
    Browse the repository at this point in the history
  24. cleanup

    telamonian committed Aug 14, 2019
    Copy the full SHA
    fde4939 View commit details
    Browse the repository at this point in the history
  25. fixed override method

    telamonian committed Aug 14, 2019
    Copy the full SHA
    6bf50a9 View commit details
    Browse the repository at this point in the history
  26. Copy the full SHA
    f291e91 View commit details
    Browse the repository at this point in the history
  27. Copy the full SHA
    6d52073 View commit details
    Browse the repository at this point in the history
  28. fixed issues remaining from rebase

    All icons now working well, barring a few issues from the phosphor hacks
    telamonian committed Aug 14, 2019
    Copy the full SHA
    96af4cb View commit details
    Browse the repository at this point in the history
  29. Copy the full SHA
    33fca86 View commit details
    Browse the repository at this point in the history
  30. progress

    telamonian committed Aug 14, 2019
    Copy the full SHA
    538e303 View commit details
    Browse the repository at this point in the history
  31. "fixed" doc build issue

    adding "lib.dom.iterable.d.ts" fixed one issue, but for some reason had to remove defaultIcons from icon.tsx to fix the rest
    telamonian committed Aug 14, 2019
    Copy the full SHA
    6d434db View commit details
    Browse the repository at this point in the history
  32. Copy the full SHA
    bc8d92b View commit details
    Browse the repository at this point in the history
  33. Copy the full SHA
    f9cf2d0 View commit details
    Browse the repository at this point in the history
  34. Copy the full SHA
    5836216 View commit details
    Browse the repository at this point in the history
  35. Copy the full SHA
    97c6cb6 View commit details
    Browse the repository at this point in the history
  36. cleanup, fixed vdom icon

    telamonian committed Aug 14, 2019
    Copy the full SHA
    f9d0d69 View commit details
    Browse the repository at this point in the history
  37. Copy the full SHA
    1d384f5 View commit details
    Browse the repository at this point in the history
  38. Copy the full SHA
    7208024 View commit details
    Browse the repository at this point in the history
  39. fixes following rebase

    telamonian committed Aug 14, 2019
    Copy the full SHA
    8629c1d View commit details
    Browse the repository at this point in the history
  40. more rebase cleanup

    telamonian committed Aug 14, 2019
    Copy the full SHA
    d249265 View commit details
    Browse the repository at this point in the history
  41. even more cleanup

    telamonian committed Aug 14, 2019
    Copy the full SHA
    a3214b0 View commit details
    Browse the repository at this point in the history
  42. Copy the full SHA
    94af99d View commit details
    Browse the repository at this point in the history
  43. fully automated import of svg icons

    Now all you need to do is place a new `.svg` in `packages/ui-components/style/icons`,
    and it will automatically get imported and added to `defaultIconRegistry`.
    telamonian committed Aug 14, 2019
    Copy the full SHA
    9c7bda9 View commit details
    Browse the repository at this point in the history
  44. Copy the full SHA
    4dd3e1d View commit details
    Browse the repository at this point in the history
  45. Copy the full SHA
    3df4e9b View commit details
    Browse the repository at this point in the history
  46. rebase fix

    telamonian committed Aug 14, 2019
    Copy the full SHA
    f737a5a View commit details
    Browse the repository at this point in the history
  47. Copy the full SHA
    d0ea82d View commit details
    Browse the repository at this point in the history
  48. cleanup

    telamonian committed Aug 14, 2019
    Copy the full SHA
    cd3d820 View commit details
    Browse the repository at this point in the history
  49. Copy the full SHA
    3423f03 View commit details
    Browse the repository at this point in the history
  50. integrity

    telamonian committed Aug 14, 2019
    Copy the full SHA
    4471232 View commit details
    Browse the repository at this point in the history
  51. Copy the full SHA
    a335b11 View commit details
    Browse the repository at this point in the history
  52. Copy the full SHA
    021ecd8 View commit details
    Browse the repository at this point in the history
  53. fixed examples, wrote docs

    telamonian committed Aug 14, 2019
    Copy the full SHA
    c3af854 View commit details
    Browse the repository at this point in the history
  54. Copy the full SHA
    277b8eb View commit details
    Browse the repository at this point in the history
  55. Copy the full SHA
    d941ce5 View commit details
    Browse the repository at this point in the history
  56. fixing up colors

    telamonian committed Aug 14, 2019
    Copy the full SHA
    fb3270b View commit details
    Browse the repository at this point in the history
  57. Copy the full SHA
    4843f18 View commit details
    Browse the repository at this point in the history
  58. Copy the full SHA
    7a74ec0 View commit details
    Browse the repository at this point in the history
  59. Copy the full SHA
    5ff8f75 View commit details
    Browse the repository at this point in the history
  60. Copy the full SHA
    f5d9618 View commit details
    Browse the repository at this point in the history
  61. more cleanup

    telamonian committed Aug 14, 2019
    Copy the full SHA
    cf81b23 View commit details
    Browse the repository at this point in the history
  62. Copy the full SHA
    dd51b13 View commit details
    Browse the repository at this point in the history
  63. Copy the full SHA
    b23d71b View commit details
    Browse the repository at this point in the history
  64. fixed up outdated icons

    telamonian committed Aug 14, 2019
    Copy the full SHA
    7b31d62 View commit details
    Browse the repository at this point in the history
  65. implemented selectable styles for inline svg icons

    equivalent to the existing static "x-icon-selectable.svg" files
    telamonian committed Aug 14, 2019
    Copy the full SHA
    ae3a1e8 View commit details
    Browse the repository at this point in the history
  66. Copy the full SHA
    13f0230 View commit details
    Browse the repository at this point in the history
  67. Copy the full SHA
    4dfeec7 View commit details
    Browse the repository at this point in the history
  68. Copy the full SHA
    144192c View commit details
    Browse the repository at this point in the history
  69. Copy the full SHA
    21133fb View commit details
    Browse the repository at this point in the history
  70. fixed launcher card icons

    telamonian committed Aug 14, 2019
    Copy the full SHA
    2fcb22a View commit details
    Browse the repository at this point in the history
  71. fixed launcher section icons

    also added a better failure mode to IconRegistry.iconReact
    telamonian committed Aug 14, 2019
    Copy the full SHA
    ae55a22 View commit details
    Browse the repository at this point in the history
  72. switched icon svg imports to auto-generated explicit import statements

    the `ensureUiComponents` function in buildutils ensures that the imports
    in iconImports.ts are synced with the contents of ui-components/style/icons.
    This runs as part of `jlpm integrity`. I also improved some docs
    telamonian committed Aug 14, 2019
    Copy the full SHA
    13f0178 View commit details
    Browse the repository at this point in the history
  73. Copy the full SHA
    eb13110 View commit details
    Browse the repository at this point in the history
  74. Copy the full SHA
    fbecad1 View commit details
    Browse the repository at this point in the history
  75. Copy the full SHA
    9929092 View commit details
    Browse the repository at this point in the history
  76. Copy the full SHA
    7713f2a View commit details
    Browse the repository at this point in the history
  77. Copy the full SHA
    dac6b0d View commit details
    Browse the repository at this point in the history
  78. Copy the full SHA
    43c151d View commit details
    Browse the repository at this point in the history
  79. Copy the full SHA
    e154617 View commit details
    Browse the repository at this point in the history
  80. Copy the full SHA
    6886d0c View commit details
    Browse the repository at this point in the history
  81. fixed CI complaint

    telamonian committed Aug 14, 2019
    Copy the full SHA
    b5a9441 View commit details
    Browse the repository at this point in the history
  82. Copy the full SHA
    e03bf24 View commit details
    Browse the repository at this point in the history
  83. integrity

    telamonian committed Aug 14, 2019
    Copy the full SHA
    cdcdaba View commit details
    Browse the repository at this point in the history
  84. integrity

    telamonian committed Aug 14, 2019
    Copy the full SHA
    180aee8 View commit details
    Browse the repository at this point in the history
  85. Copy the full SHA
    48d6cec View commit details
    Browse the repository at this point in the history