New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose icon SVG to theme CSS #6034
Commits on Aug 14, 2019
-
-
-
-
-
All svg formatting is fixed and at parity with master
Still need to expose the remaining non-theme svgs
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
fixed issues remaining from rebase
All icons now working well, barring a few issues from the phosphor hacks
-
-
-
adding "lib.dom.iterable.d.ts" fixed one issue, but for some reason had to remove defaultIcons from icon.tsx to fix the rest
-
-
-
-
-
-
-
-
-
-
-
-
fully automated import of svg icons
Now all you need to do is place a new `.svg` in `packages/ui-components/style/icons`, and it will automatically get imported and added to `defaultIconRegistry`.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
implemented
selectable
styles for inline svg iconsequivalent to the existing static "x-icon-selectable.svg" files
-
-
-
-
-
also added a better failure mode to IconRegistry.iconReact
-
switched icon svg imports to auto-generated explicit
import
statementsthe `ensureUiComponents` function in buildutils ensures that the imports in iconImports.ts are synced with the contents of ui-components/style/icons. This runs as part of `jlpm integrity`. I also improved some docs
-
-
-
-
-
-
-
-
-
-
-