Update to Vega 5 #6133
Merged
Update to Vega 5 #6133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
I believe things are correct but we need another npm release of the new package I added. Can someone help me with that? |
ian-r-rose
reviewed
Mar 30, 2019
| "vega-embed": "3.18.2" | ||
| "vega": "^5.3.1", | ||
| "vega-embed": "^4.0.0", | ||
| "vega-lite": "^3.0.0" |
There was a problem hiding this comment.
@domoritz Do these need to be specified here for any reason, or are the vega and vega-lite pulled in by vega-embed sufficient?
There was a problem hiding this comment.
Vega-Embed now only has peer dependencies. I think it's much better for you to be able to specify the versions you want regardless of the Vega-Embed version.
There was a problem hiding this comment.
Discussion is here: vega/vega-embed#136
Closed
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6128
I moved the existing extension package to jupyterlab/jupyter-renderers#184