Log out and Shut down are two words when used as verbs #6299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
jasongrout
force-pushed
the
logout-menu-name
branch
from
05d9c05
to
8d8cbb2
Compare
|
This is consistent with menu entries for similar things on windows, macOS, and linux. |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Expands on #6087
See also http://www.notaverb.com/shutdown
Code changes
Log out is added to the command palette.
User-facing changes
Log out and shut down are two words when used as a verb/action. This sweeps through the codebase attempting to correct our use of these terms.
Backwards-incompatible changes
N/A