Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Raises-exception #6424

Merged
merged 3 commits into from May 29, 2019
Merged

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented May 28, 2019

References

Fixes #2412

Code changes

Changes the stop_on_error behavior of OutputArea.execute to account for raises-exception tags.

User-facing changes

Users are able to use the raises-exception tags in the same way they have been available to in nbconvert and notebook. cf jupyter/notebook#2549 , jupyter/nbconvert#684

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 merged commit b49a6c3 into jupyterlab:master May 29, 2019
@blink1073 blink1073 deleted the raises-exception branch June 2, 2019 09:49
@sleighsoft
Copy link

sleighsoft commented Jul 17, 2019

@blink1073
Running jupyterlab 1.02.

I have the following cell

function_2('Hello World') # This does not work, missing second positional argument

Cell metadata:

{
    "tags": [
        "raises-exception"
    ]
}

Error when running the cell

---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
<ipython-input-25-31feb4d8c340> in <module>
----> 1 function_2('Hello World') # This does not work, missing second positional argument

NameError: name 'function_2' is not defined

Problem: Juptyerlab still stops at that exception when "Run All Cells". Did I misunderstand something?

@joelostblom
Copy link
Contributor

joelostblom commented Aug 14, 2019

@sleighsoft I am having the same issue on jl-1.0.5 (it works fine in the classic notebook). Did you find a solution?

@sleighsoft
Copy link

Not yet

@vidartf
Copy link
Member

vidartf commented Aug 15, 2019

See current discussion in #7015.

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Sep 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Feature Parity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow raises-exception to continue
4 participants