New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launcher UX improvements #6529
Launcher UX improvements #6529
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
Rebase needed, the CSS will go in base.css following #6395 |
Ha, I was about to rebase this, but it is against your master branch. 😉 |
Looks good for the minimum we ought to do pre 1.0. Small nit-pick, is it possible to shrink the two lines when there's only one line of text? The margins start looking a little off-balance on the 'other' category. I think it makes sense to leave it for now and address in launcher re-design. |
Failed test is unrelated async timeout in notebook tests. |
This does need to be rebased, though! @ellisonbg - @blink1073 pointed out that this PR is from your master branch. IIRC, GitHub doesn't allow us to push to your master branch, so we can't do this rebase for you :). |
Superseded by #6587 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion. |
References
Partial fix for #3795 intended for 1.0. A more ambitious improvement is being done in #5953.
Code changes
tabindex
and pressing enter when a card is focused will callonclick
to open the activity. This enables keyboard interaction with the launcher.User-facing changes
More examples:
Backwards-incompatible changes
None.