Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher UX improvements #6529

Closed
wants to merge 2 commits into from
Closed

Conversation

ellisonbg
Copy link
Contributor

References

Partial fix for #3795 intended for 1.0. A more ambitious improvement is being done in #5953.

Code changes

  • Each launcher card now has a valid tabindex and pressing enter when a card is focused will call onclick to open the activity. This enables keyboard interaction with the launcher.
  • The title of the card is now the kernel name if it is a notebook or console.

User-facing changes

  • Name of kernel now wraps to 2 lines to make longer kernel names visible.
  • Additional styling for active and focus states of cards.

Screen Shot 2019-06-10 at 3 07 06 PM

More examples:

Screen Shot 2019-06-10 at 3 09 36 PM

Backwards-incompatible changes

None.

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member

Rebase needed, the CSS will go in base.css following #6395

@blink1073
Copy link
Member

Ha, I was about to rebase this, but it is against your master branch. 😉

@tgeorgeux
Copy link
Contributor

Looks good for the minimum we ought to do pre 1.0. Small nit-pick, is it possible to shrink the two lines when there's only one line of text? The margins start looking a little off-balance on the 'other' category. I think it makes sense to leave it for now and address in launcher re-design.

@jasongrout
Copy link
Contributor

Failed test is unrelated async timeout in notebook tests.

@jasongrout
Copy link
Contributor

This does need to be rebased, though!

@ellisonbg - @blink1073 pointed out that this PR is from your master branch. IIRC, GitHub doesn't allow us to push to your master branch, so we can't do this rebase for you :).

@jasongrout
Copy link
Contributor

Superseded by #6587

@jasongrout jasongrout closed this Jun 15, 2019
@jasongrout jasongrout added this to the Reference milestone Jun 15, 2019
@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@jasongrout jasongrout added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants