Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the FAQ extension #6628

Merged
merged 5 commits into from Jun 19, 2019
Merged

Remove the FAQ extension #6628

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6f63a8
Remove faq package.
ellisonbg Jun 18, 2019
445a3ad
Integrity update.
ellisonbg Jun 18, 2019
60a7637
Delete a few more mentions of the faq extension.
jasongrout Jun 19, 2019
6675977
Delete more mentions of the faq.
jasongrout Jun 19, 2019
22bc8eb
Handle lint errors.
jasongrout Jun 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion buildutils/src/ensure-repo.ts
View file
Open in desktop
Expand Up @@ -52,7 +52,6 @@ let SKIP_CSS: Dict<string[]> = {
],
'@jupyterlab/filebrowser': ['@jupyterlab/statusbar'],
'@jupyterlab/fileeditor': ['@jupyterlab/statusbar'],
'@jupyterlab/faq-extension': ['@jupyterlab/application'],
'@jupyterlab/help-extension': ['@jupyterlab/application'],
'@jupyterlab/shortcuts-extension': ['@jupyterlab/application'],
'@jupyterlab/tabmanager-extension': ['@jupyterlab/application'],
Expand Down
1 change: 0 additions & 1 deletion dev_mode/imports.css
View file
Open in desktop
Expand Up @@ -9,7 +9,6 @@
@import url('~@jupyterlab/docmanager-extension/style/index.css');
@import url('~@jupyterlab/documentsearch-extension/style/index.css');
@import url('~@jupyterlab/extensionmanager-extension/style/index.css');
@import url('~@jupyterlab/faq-extension/style/index.css');
@import url('~@jupyterlab/filebrowser-extension/style/index.css');
@import url('~@jupyterlab/fileeditor-extension/style/index.css');
@import url('~@jupyterlab/help-extension/style/index.css');
Expand Down
3 changes: 0 additions & 3 deletions dev_mode/package.json
View file
Open in desktop
Expand Up @@ -27,7 +27,6 @@
"@jupyterlab/documentsearch-extension": "^1.0.0-alpha.13",
"@jupyterlab/extensionmanager": "^1.0.0-alpha.11",
"@jupyterlab/extensionmanager-extension": "^1.0.0-alpha.11",
"@jupyterlab/faq-extension": "^1.0.0-alpha.11",
"@jupyterlab/filebrowser": "^1.0.0-alpha.11",
"@jupyterlab/filebrowser-extension": "^1.0.0-alpha.11",
"@jupyterlab/fileeditor": "^1.0.0-alpha.11",
Expand Down Expand Up @@ -126,7 +125,6 @@
"@jupyterlab/docmanager-extension": "",
"@jupyterlab/documentsearch-extension": "",
"@jupyterlab/extensionmanager-extension": "",
"@jupyterlab/faq-extension": "",
"@jupyterlab/filebrowser-extension": "",
"@jupyterlab/fileeditor-extension": "",
"@jupyterlab/help-extension": "",
Expand Down Expand Up @@ -222,7 +220,6 @@
"@jupyterlab/docmanager-extension": "../packages/docmanager-extension",
"@jupyterlab/documentsearch-extension": "../packages/documentsearch-extension",
"@jupyterlab/extensionmanager-extension": "../packages/extensionmanager-extension",
"@jupyterlab/faq-extension": "../packages/faq-extension",
"@jupyterlab/filebrowser-extension": "../packages/filebrowser-extension",
"@jupyterlab/fileeditor-extension": "../packages/fileeditor-extension",
"@jupyterlab/help-extension": "../packages/help-extension",
Expand Down
1 change: 0 additions & 1 deletion examples/app/package.json
View file
Open in desktop
Expand Up @@ -17,7 +17,6 @@
"@jupyterlab/console-extension": "^1.0.0-alpha.11",
"@jupyterlab/csvviewer-extension": "^1.0.0-alpha.12",
"@jupyterlab/docmanager-extension": "^1.0.0-alpha.11",
"@jupyterlab/faq-extension": "^1.0.0-alpha.11",
"@jupyterlab/filebrowser-extension": "^1.0.0-alpha.11",
"@jupyterlab/fileeditor-extension": "^1.0.0-alpha.11",
"@jupyterlab/help-extension": "^1.0.0-alpha.11",
Expand Down
3 changes: 0 additions & 3 deletions packages/faq-extension/README.md
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions packages/faq-extension/faq.md
View file
Open in desktop

This file was deleted.

56 changes: 0 additions & 56 deletions packages/faq-extension/package.json
View file
Open in desktop

This file was deleted.

105 changes: 0 additions & 105 deletions packages/faq-extension/src/index.ts
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions packages/faq-extension/style/base.css
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions packages/faq-extension/style/index.css
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions packages/faq-extension/tdoptions.json
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions packages/faq-extension/tsconfig.json
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/help-extension/src/index.tsx
View file
Open in desktop
Expand Up @@ -151,7 +151,6 @@ function activate(
const helpMenu = mainMenu.helpMenu;
const labGroup = [
CommandIDs.about,
'faq-jupyterlab:open',
CommandIDs.launchClassic
].map(command => ({ command }));
helpMenu.addGroup(labGroup, 0);
Expand Down
1 change: 0 additions & 1 deletion packages/metapackage/package.json
View file
Open in desktop
Expand Up @@ -54,7 +54,6 @@
"@jupyterlab/documentsearch-extension": "^1.0.0-alpha.13",
"@jupyterlab/extensionmanager": "^1.0.0-alpha.11",
"@jupyterlab/extensionmanager-extension": "^1.0.0-alpha.11",
"@jupyterlab/faq-extension": "^1.0.0-alpha.11",
"@jupyterlab/filebrowser": "^1.0.0-alpha.11",
"@jupyterlab/filebrowser-extension": "^1.0.0-alpha.11",
"@jupyterlab/fileeditor": "^1.0.0-alpha.11",
Expand Down
1 change: 0 additions & 1 deletion packages/metapackage/src/index.ts
View file
Open in desktop
Expand Up @@ -22,7 +22,6 @@ import '@jupyterlab/docmanager-extension';
import '@jupyterlab/docregistry';
import '@jupyterlab/extensionmanager';
import '@jupyterlab/extensionmanager-extension';
import '@jupyterlab/faq-extension';
import '@jupyterlab/filebrowser';
import '@jupyterlab/filebrowser-extension';
import '@jupyterlab/fileeditor';
Expand Down
3 changes: 0 additions & 3 deletions packages/metapackage/tsconfig.json
View file
Open in desktop
Expand Up @@ -75,9 +75,6 @@
{
"path": "../extensionmanager-extension"
},
{
"path": "../faq-extension"
},
{
"path": "../filebrowser"
},
Expand Down