Remove the settings editor bug icon and always display the error inspector #6653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
The command |
|
I really liked that we had an excuse to use that cute little bug 🐞 icon, but the greater good ... |
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion. |
jasongrout
added
the
status:resolved-locked
krassowski
added a commit
to krassowski/jupyterlab
that referenced
this pull request
Mar 20, 2023
fcollonval
pushed a commit
that referenced
this pull request
Mar 31, 2023
* Disallow more than one bare HTML tag * Remove dangling tab-manager references these should have been removed in #8886 * Remove dialog button rule with complex selector which has no effect * Remove stray style which should have been removed with #6653 * Remove one more dangling tab-manager style * Enable `selector-max-class` stylelint rule * Enable `selector-max-compound-selectors` stylelint rule * Enable selector-max-universal: 1 to prevent very bad CSS (while still allowing somewhat bad CSS for now). * Make use of `stylelint-disable-next-line` where practical
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #6623
Code changes
User-facing changes
Removes the bug icon in the settings editor and always displays the error messages.
Backwards-incompatible changes
Removes some commands and accessors dealing with hiding/showing the debug messages.