Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background rocket fix #6660

Closed
wants to merge 2 commits into from
Closed

Conversation

afonit
Copy link

@afonit afonit commented Jun 20, 2019

Taking a stab at removing the backgrounds of the two icons mentioned here:
#6624

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@ellisonbg
Copy link
Contributor

Sorry about the mis-communication. I ended up doing a huge refactor of icons in #6664 and we ended up moving away from the rocket icon altogether, in favor of a Material Design icon (its launch one):

https://material.io/tools/icons/?search=launch&style=baseline

There were two reasons for this: 1) we don't know where the rocket came from, and are a bit unsure about its license - especially as we modify it 2) we want to maintain as few custom icons as possible, so if there is one from MD that will work, we want to use it.

@ellisonbg ellisonbg closed this Jun 20, 2019
@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@jasongrout jasongrout added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants