move contextual help to the help menu

[ivanov]

No description provided.

[jupyterlab-dev-mode]

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link:

[ivanov]

[jasongrout]

+1 to moving it to the help menu.

Can we make it a separate group just after the About and Launch classic? I think it really is different than those items. So the menu would be:

About
Launch classic
----
Open Contextual Help
-----
JupyterLab Reference
JupyterLab FAQ
Jupyter Reference
Markdown Reference
---
<rest of items>

(Notice I also rearranged the jlab/jupyter reference group - I think this order makes more sense, to put the jlab stuff first)

[jasongrout]

Hmmm---and thinking about it, most of those items are "open" actions. It's a bit weird that only one of them says "Open". @ellisonbg, thoughts?

[ivanov]

Discussed this in person with @ellisonbg, who was 50-50 on remove or keeping "Open " in the menu name. At first I was going to keep it, but then I figured that in the command palette, type "open" would select the contextual help as the first item, which is not a good user experience, so I dropped open, here's what it looks like now (and as a bonus, contextual help is fairly high in the command listing with an empty entry, so it's somewhat discoverable that way, too. We will definitely want to let users know about this rename and move of the menu item in the changelog.

[ian-r-rose]

Thanks @ivanov, like it needs a rebase.

[ian-r-rose]

I like this check. We should do more of these.

[ian-r-rose]

Looks like a legitimate test failure.

[ivanov]

@saulshanabrook was concerned about the [null].map(...), but I checked and the menu item works and just gets filtered out.:

[ian-r-rose]

This works even if the inspector is not available. If you want to change the [null] behavior, can you do it in a follow-up, @saulshanabrook?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.