Build Vega bundles separately from other code #6714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes jupyterlab#6709, and is a follow up to jupyterlab#6572. It separates building vega assets from the rest of our package management. That way, we can avoid any hoisting issues that we were seeing (possibly from yarnpkg/yarn#5520). To test this, you can try this notebook which should render both versions without errors: https://gist.github.com/saulshanabrook/97c28550ab12e684adc3c325038537ce
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Did you mean to check in those two lock files? |
|
Yeah I did, I figure it makes the builds more reproducible? |
|
Fair enough, this LGTM! |
blink1073
approved these changes
Jun 27, 2019
To fix integrity checks in CI
|
Thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion. |
jasongrout
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This fixes #6709, and is a follow up to #6572.
Code changes
It separates building
vega assets from the rest of our package management. That way, we can
avoid any hoisting issues that we were seeing (possibly from yarnpkg/yarn#5520).
User-facing changes
Fixes displaying vega lite 3
To test this, you can try this notebook which should render
both versions without errors:
https://gist.github.com/saulshanabrook/97c28550ab12e684adc3c325038537ce
Backwards-incompatible changes