Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factory overrides #6813

Merged
merged 9 commits into from Aug 22, 2019
Merged

Factory overrides #6813

merged 9 commits into from Aug 22, 2019

Commits on Aug 22, 2019

  1. Allow user overrides of default viewers.

    @ian-r-rose @afshin
    ian-r-rose authored and afshin committed Aug 22, 2019
    Copy the full SHA
    98afa9e View commit details
    Browse the repository at this point in the history

  2. Unset any overrides if they are removed.

    @ian-r-rose @afshin
    ian-r-rose authored and afshin committed Aug 22, 2019
    Copy the full SHA
    1eff821 View commit details
    Browse the repository at this point in the history

  3. Tests and error handling.

    @ian-r-rose @afshin
    ian-r-rose authored and afshin committed Aug 22, 2019
    Copy the full SHA
    905cda8 View commit details
    Browse the repository at this point in the history

  4. Handle some edge cases a bit better.

    @ian-r-rose @afshin
    ian-r-rose authored and afshin committed Aug 22, 2019
    Copy the full SHA
    b713489 View commit details
    Browse the repository at this point in the history

  5. Check for invalid widget factory name.

    @ian-r-rose @afshin
    ian-r-rose authored and afshin committed Aug 22, 2019
    Copy the full SHA
    9b5a715 View commit details
    Browse the repository at this point in the history

  6. Remove override if the factory is disposed.

    @ian-r-rose @afshin
    ian-r-rose authored and afshin committed Aug 22, 2019
    Copy the full SHA
    a9610a6 View commit details
    Browse the repository at this point in the history

  7. Update typedoc to es2017.

    @ian-r-rose @afshin
    ian-r-rose authored and afshin committed Aug 22, 2019
    Copy the full SHA
    a210fa5 View commit details
    Browse the repository at this point in the history

  8. Auto-generate a help string for the setting with available viewers and 

    file types.
    @ian-r-rose @afshin
    ian-r-rose authored and afshin committed Aug 22, 2019
    Copy the full SHA
    cf7dc8b View commit details
    Browse the repository at this point in the history

  9. Run linter.

    @afshin
    afshin committed Aug 22, 2019
    Copy the full SHA
    2c15805 View commit details
    Browse the repository at this point in the history