accept query parameter to optionally change file browser location #6875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
@afshin - when do you expect to be able to review this? This solves a problem we have as well. |
blink1073
reviewed
Aug 20, 2019
| @@ -275,6 +275,11 @@ const tree: JupyterFrontEndPlugin<void> = { | |||
| // Remove the tree portion of the URL leaving the rest intact. | |||
| router.navigate(url); | |||
|
|
|||
| const query = URLExt.queryStringToObject(args.search); | |||
| if (query.filebrowserPath) { | |||
There was a problem hiding this comment.
I'd prefer to stick with URI tradition and use file-browser-path for the parameter name. cf https://stackoverflow.com/a/18450653
|
@blink1073 thanks for your feedback, I changed the parameter format. |
|
Thanks @dmarth and congratulations on your first PR to JupyterLab! 🚀 |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
#6874
Code changes
It is now possible to pass a query parameter called
filebrowserPathto the tree route handler. If this parameter is set, the filebrowser is navigated to this path.User-facing changes
By default, the behavior does not change for the user. Only if the
filebrowserPathparameter is passed, the location of the filebrowser differs from the location of the opened notebook.For example, the URL
/lab/tree/test/example.ipynb?filebrowserPath=/shows the notebooktest/example.ipynbwhile still showing the workspace root directory in the filebrowser (instead of thetestdirectory).