Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make handling comm messages optional in a kernel connection. #6929

Merged
merged 5 commits into from Aug 2, 2019

Commits on Aug 1, 2019

  1. Make handling comm messages optional in a kernel connection.

    The comm message protocol currently has implicit assumptions that only
    one kernel connection is handling comm messages. This option allows a
    kernel connection to opt out of handling comms.
    
    See jupyter/jupyter_client#263
    
    This fixes the error where ipywidgets stops working if you open a notebook and a console to the same kernel, since the console automatically closes all comms since it does not have the comm target registered.
    jasongrout committed Aug 1, 2019
    Copy the full SHA
    72a49ea View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    ba94eed View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    4bcfe97 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    b798bcd View commit details
    Browse the repository at this point in the history
  5. Make a comm test more robust.

    It seems that sometimes the defaultKernel wasn’t found in the private list of running kernels…
    jasongrout committed Aug 1, 2019
    Copy the full SHA
    976fbb0 View commit details
    Browse the repository at this point in the history