Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly escape template variables #7016

Merged
merged 4 commits into from Aug 16, 2019
Merged

Properly escape template variables #7016

merged 4 commits into from Aug 16, 2019

Commits on Aug 14, 2019

  1. Properly escape template variables

    @jasongrout
    jasongrout committed Aug 14, 2019
    Copy the full SHA
    228ee91 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2019

  1. Do not try to overly escape the notebook version info anymore.

    @jasongrout
    jasongrout committed Aug 16, 2019
    Copy the full SHA
    f655977 View commit details
    Browse the repository at this point in the history

  2. Escape instead of url encode in the jinja template 

    urlencode will escape :, but we want to preserve : if there is a full url.
    @jasongrout
    jasongrout committed Aug 16, 2019
    Copy the full SHA
    d81f6d8 View commit details
    Browse the repository at this point in the history

  3. Correct escaping in other templates we distribute.

    @jasongrout
    jasongrout committed Aug 16, 2019
    Copy the full SHA
    11828db View commit details
    Browse the repository at this point in the history