New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build util paths for Windows #7019
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Should we backport this? |
Sure, why not. |
@meeseeksdev backport to 1.0.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
nvm, not worth doing manually |
Cleaned up the label. |
References
Fixes build utils for Windows after #6034.
Also ensures that file contents line endings are normalized, to prevent line-ending only diffs.
Code changes
Replaces path sep with '/' to normalize slashes.
Replaces '\n' with the current line ending of the file in
ensureFile
.User-facing changes
None
Backwards-incompatible changes
None