Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

progress on icons: added inline svg icon support to toolbar buttons #7192

Merged
merged 14 commits into from Sep 16, 2019
Merged

progress on icons: added inline svg icon support to toolbar buttons #7192

merged 14 commits into from Sep 16, 2019

Commits on Sep 11, 2019

  1. added fallback flag to icon, moved toolbar to new icon handling 

    also added some docstrings to the icon-related interfaces
    @telamonian
    telamonian committed Sep 11, 2019
    Copy the full SHA
    bdb632c View commit details
    Browse the repository at this point in the history

  2. fixed up icon fallback in listing

    @telamonian
    telamonian committed Sep 11, 2019
    Copy the full SHA
    4384362 View commit details
    Browse the repository at this point in the history

  3. migrated toolbar button svg files to ui-components

    @telamonian
    telamonian committed Sep 11, 2019
    Copy the full SHA
    0bc6d9f View commit details
    Browse the repository at this point in the history

  4. added toolbar icons to DefaultIconRegistry

    @telamonian
    telamonian committed Sep 11, 2019
    Copy the full SHA
    baa37b0 View commit details
    Browse the repository at this point in the history

  5. cleaned up redundant svg files in theme-dark

    @telamonian
    telamonian committed Sep 11, 2019
    Copy the full SHA
    5d57872 View commit details
    Browse the repository at this point in the history

  6. fixed up msgs generated by ensureFile

    @telamonian
    telamonian committed Sep 11, 2019
    Copy the full SHA
    b255f23 View commit details
    Browse the repository at this point in the history

  7. removed old CSS for toolbar icon background svgs

    @telamonian
    telamonian committed Sep 11, 2019
    Copy the full SHA
    4e3b394 View commit details
    Browse the repository at this point in the history

  8. cleanup

    @telamonian
    telamonian committed Sep 11, 2019
    Copy the full SHA
    816948c View commit details
    Browse the repository at this point in the history

  9. added 'toolbarButton' icon styling kind

    @telamonian
    telamonian committed Sep 11, 2019
    Copy the full SHA
    956c744 View commit details
    Browse the repository at this point in the history

  10. fixed up toolbar icon-related unittests

    @telamonian
    telamonian committed Sep 11, 2019
    Copy the full SHA
    09663df View commit details
    Browse the repository at this point in the history

  11. fixed up toolbar unittests in test-notebook

    @telamonian
    telamonian committed Sep 11, 2019
    Copy the full SHA
    224c7e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2019

  1. optionally replace import -> require when generating iconimports.ts

    @telamonian
    telamonian committed Sep 12, 2019
    Copy the full SHA
    f8642d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2019

  1. fixes jupyterlab#7189, jupyterlab/jupyterlab-git#411

    @telamonian
    telamonian committed Sep 14, 2019
    Copy the full SHA
    0d59934 View commit details
    Browse the repository at this point in the history

  2. fix to deprecated docstrings

    @telamonian
    telamonian committed Sep 14, 2019
    Copy the full SHA
    3220cf9 View commit details
    Browse the repository at this point in the history