Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #7264: use default app_dir when app_dir == '' #7268

Merged
merged 1 commit into from Sep 27, 2019
Merged

fixes #7264: use default app_dir when app_dir == '' #7268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions jupyterlab/commands.py
View file
Open in desktop
Expand Up @@ -302,6 +302,11 @@ def __init__(self, logger=None, core_config=None, **kwargs):
kwargs['core_config'] = core_config
if logger is not None:
kwargs['logger'] = logger

# use the default if app_dir is empty
if 'app_dir' in kwargs and not kwargs['app_dir']:
kwargs.pop('app_dir')

super(AppOptions, self).__init__(**kwargs)

app_dir = Unicode(help='The application directory')
Expand Down