Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused side parameter #7277

Merged
merged 1 commit into from Oct 1, 2019

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 28, 2019

References

Spotted while looking at #7278.

Code changes

Remove unused side parameter.

User-facing changes

None

Backwards-incompatible changes

None (in a private namespace)

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added this to the 1.2 milestone Oct 1, 2019
@blink1073 blink1073 merged commit c0237ab into jupyterlab:master Oct 1, 2019
@jtpio jtpio deleted the unused-side-parameter branch October 1, 2019 04:59
@jasongrout jasongrout modified the milestones: 1.2, 2.0 Oct 11, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Nov 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance pkg:application status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants