Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds JLIcon, an easier way to consume icons as SVG nodes #7299

Closed
wants to merge 41 commits into from
Closed

Adds JLIcon, an easier way to consume icons as SVG nodes #7299

wants to merge 41 commits into from

Commits on Dec 25, 2019

  1. starting work on JLIcon, to be used as an icon class wrapper

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    d5dbfbe View commit details
    Browse the repository at this point in the history

  2. dynamically create JLIcon class within a function

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    9a5ed5f View commit details
    Browse the repository at this point in the history

  3. added static JLIcon.element, returns an HTMLElement

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    e865999 View commit details
    Browse the repository at this point in the history

  4. set up ref forwarding in JLIcon

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    c47b74f View commit details
    Browse the repository at this point in the history

  5. simplified typing of createIcon return type

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    bcf2ac0 View commit details
    Browse the repository at this point in the history

  6. all of the wrapped icons now get autogenerated by integrity 

    also had to revert the cleanup of createIcon's return type. The new
way didn't work since some template parameters weren't specified
    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    b7f63c1 View commit details
    Browse the repository at this point in the history

  7. added explicitly declared return type to createIcon 

    also added explicit types to the call to `React.forwardRef`
within `createIcon`
    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    d633c97 View commit details
    Browse the repository at this point in the history

  8. simplified createIcon function by refactoring it into JLIcon class 

    individual icons are now instances of JLIcon class
    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    9891483 View commit details
    Browse the repository at this point in the history

  9. refactored JLIcon.react from accessor => property 

    more efficient, since this way the component returned by .react is
created only once (as part of the constructor) and cached. Need to be
careful with future changes to JLIcon.constructor, as execution order
of initializers is now important
    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    d9157b9 View commit details
    Browse the repository at this point in the history

  10. fixed up docstrings in JLIcon namespace

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    a42ebe4 View commit details
    Browse the repository at this point in the history

  11. experimenting with blending phosphor/react vdom

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    5d53122 View commit details
    Browse the repository at this point in the history

  12. all tabbar icons now rendered by blended react/phosphor vdom elements 

    requires the changes in the phosphorjs/phosphor#437 PR
    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    29696b4 View commit details
    Browse the repository at this point in the history

  13. fixed sidebar tab icons; styling still isn't right 

    currently can't use two different styles for tab icons passed to phosphor.
Also in this commit: an experiment in constructing a bare svg react component
from a raw string (contained in jlicon.tsx)
    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    5cd5b01 View commit details
    Browse the repository at this point in the history

  14. integrity

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    0150060 View commit details
    Browse the repository at this point in the history

  15. fixing up the text editor icon

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    c169aa7 View commit details
    Browse the repository at this point in the history

  16. fixed text editor icon name

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    f219143 View commit details
    Browse the repository at this point in the history

  17. progress fixing text editor icon

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    01bf019 View commit details
    Browse the repository at this point in the history

  18. finished fixing text editor icon

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    13636c6 View commit details
    Browse the repository at this point in the history

  19. human readability formatting pass of filetype icon svg 

    punted on issue of tabs-vs-spaces for indents
    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    3207458 View commit details
    Browse the repository at this point in the history

  20. switch filebrowser to newest JLIcon icon handling

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    637cac5 View commit details
    Browse the repository at this point in the history

  21. finally got react to parse/render bare svg element without outer div

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    48b0b82 View commit details
    Browse the repository at this point in the history

  22. bugfix for camelCase function

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    5eb653d View commit details
    Browse the repository at this point in the history

  23. fixed container handling by JLIcon methods

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    5667d2e View commit details
    Browse the repository at this point in the history

  24. fixed styling of tab manager tab icons

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    b53f50e View commit details
    Browse the repository at this point in the history

  25. fixed memory leak in browser icons; updates for latest version of hpass

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    0168548 View commit details
    Browse the repository at this point in the history

  26. fixed memory leak; JLIcon nows cleans up after itself when passed to … 

    …phosphor
    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    8931a8f View commit details
    Browse the repository at this point in the history

  27. post phosphor => lumino rebase cleanup

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    70da61c View commit details
    Browse the repository at this point in the history

  28. progress

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    7e0808c View commit details
    Browse the repository at this point in the history

  29. progress

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    28cdc46 View commit details
    Browse the repository at this point in the history

  30. JLIcon prototype is now feature complete and lumino vdom friendly

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    55a2966 View commit details
    Browse the repository at this point in the history

  31. type/signature fixes

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    1bec1ee View commit details
    Browse the repository at this point in the history

  32. fixed bug in static Map init

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    21f8d65 View commit details
    Browse the repository at this point in the history

  33. fixed tabmanager icon styling

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    74c818c View commit details
    Browse the repository at this point in the history

  34. fixed style for dockpanel tab icons

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    7a8361b View commit details
    Browse the repository at this point in the history

  35. signature cleanup

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    09132cb View commit details
    Browse the repository at this point in the history

  36. simplified JLIcon styling for lumino; moved all tab icons to JLIcon 

    All filetype icons in tabs and all extension icons in the sidebar are now JLIcons
    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    7004dd5 View commit details
    Browse the repository at this point in the history

  37. docs and integrity

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    6b997b3 View commit details
    Browse the repository at this point in the history

  38. post-rebase cleanup and bugfixes

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    6d38176 View commit details
    Browse the repository at this point in the history

  39. integrity

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    c05e50f View commit details
    Browse the repository at this point in the history

  40. picked lint

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    a5a05ae View commit details
    Browse the repository at this point in the history

  41. configure all linters to ignore generated iconimports.ts

    @telamonian
    telamonian committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    247b1cd View commit details
    Browse the repository at this point in the history