Skip custom click behavior on links when the download attribute is set #7311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #5443
Code changes
User-facing changes
The presumption here is that if an anchor node has a download attribute explicitly set, the user really does want to download the file rather than opening the file in JLab.
Backwards-incompatible changes
None - perhaps this should be backported to 1.2?
An incompatible change we probably should do in the future is tighten up the linkHandler signature to insist that the node is an anchor node.