Moved back settingRegistry dependant commands #7332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a still unclear issue, when passing settingRegistry to functions it changes the beahvior of the commands that use it. This change moves the six commands that interact with settingRegistry back to index.ts from commands.ts where they were oved in jupyterlab#6904 This fixes jupyterlab#7295
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
@jasongrout I found a bug in my code from last month, this fix needs to go out with 1.2 and 2.0 to prevent introducing the bug into a release. Given this I prioritized fixing the bug over figuring out why it happens. Also after my PR was merged I discovered that there is most like no cases where the addCommand functions I introduced would be used by outside code, so this change would not hurt the original intent of my PR |
|
This PR doesn't fix the issue for me. I explored the problem a bit in #7295 (comment) |
ajbozarth
added a commit
to ajbozarth/jupyterlab
that referenced
this pull request
Oct 13, 2019
After further testing od my previous pr jupyterlab#7332 I discovered that the core issue was that config was a var not a const. So the commands were using the value of config at creation in thier updates rather than it's value at runtime.
|
Closing in favor of #7350 |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Bug raised in #7295
PR that introduced the bug #6904
Code changes
Due to a still unclear issue, when passing settingRegistry to functions it changes the behavior of the commands that use it.
This change moves the six commands that interact with
settingRegistryback toindex.tsfromcommands.ts, where they were moved to in #6904User-facing changes
The setting for
Line Numbers,Word Wrap, andMatch Bracketsare no longer reset to their default found inCodeEditor.defaultConfigwhen a change toeditorConfigin thesettingRegistryis made (eg. changing tab or font sizes).Backwards-incompatible changes
None