Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Text Editor config var into commands.ts #7350

Merged
merged 1 commit into from Oct 15, 2019
Merged

Moved Text Editor config var into commands.ts #7350

merged 1 commit into from Oct 15, 2019

Commits on Oct 13, 2019

  1. Moved config into commands.ts 

    After further testing od my previous pr jupyterlab#7332 I discovered that
the core issue was that config was a var not a const. So the
commands were using the value of config at creation in thier updates
rather than it's value at runtime.
    @ajbozarth
    ajbozarth committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    9be9213 View commit details
    Browse the repository at this point in the history