Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up log console api a bit #7379

Merged
merged 42 commits into from
Oct 22, 2019
Merged

Commits on Oct 16, 2019

  1. Configuration menu
    Copy the full SHA
    9bc63f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da0e950 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Change toolbar buttons to command buttons so they can be disabled eas…

    …ily.
    
    This also lets us set up keyboard shortcuts for the buttons, etc.
    jasongrout committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    38db0bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2afb2ae View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    177f20f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6532dfa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    04e60cc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c8c20a5 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d6e9e79 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    341782f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    db23c4d View commit details
    Browse the repository at this point in the history
  10. Push the max log size down to the model

    We also threaded the limit through the constructors so that the extension has sole control over the limit.
    jasongrout committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    2da6a4b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2105a18 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    75f66d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. Configuration menu
    Copy the full SHA
    6aa7beb View commit details
    Browse the repository at this point in the history
  2. Change log console highlight to use brand color.

    The info color does not match well with the hardcoded status bar colors, especially in dark mode.
    jasongrout committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    8fd895e View commit details
    Browse the repository at this point in the history
  3. Track whether a log has ever had a message, and hide the status bar w…

    …idget for inactive logs.
    jasongrout committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    540c4c0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6188897 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f8ddaec View commit details
    Browse the repository at this point in the history
  6. Use the new icon system for log console.

    This allows the log console icons to look nice in all themes.
    jasongrout committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    abe11d0 View commit details
    Browse the repository at this point in the history
  7. Add a log console plugin to log all notebook outputs.

    This is for testing purposes. It probably should be reverted later as logging all notebook outputs is rather noisy in the log.
    jasongrout committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    4407953 View commit details
    Browse the repository at this point in the history
  8. Exploration for how to communicate to the right components that curre…

    …nt messages have been displayed.
    jasongrout committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    fbfd865 View commit details
    Browse the repository at this point in the history
  9. Revert "Exploration for how to communicate to the right components th…

    …at current messages have been displayed."
    
    This reverts commit fbfd865.
    jasongrout committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    da58234 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3638e3c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e2bd8d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2019

  1. Add a scrolling widget.

    It works great when you manually adjust the heights of the widgets as they are laid out. Once we figure out how to get the scrolling widget to have the appropriate height, I think this is good to go!
    jasongrout committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    60cf63d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a0fc42b View commit details
    Browse the repository at this point in the history
  3. Move the scrolling widget back to the LogConsolePanel.

    We have two basic approaches - we can have the scrolling behavior at the MainAreaWidget level (one intersection observer for the entire log console, but harder api since there is another wrapper around the content), or the scrolling behavior at the output area level (inside log console, which means an intersection observer for each output area, but simpler top-level api). I’m opting for the latter, and a bonus is that perhaps the scroll position can be preserved across different logs.
    
    We could also make a new main area widget with the scrolling behavior, but that seems a bit too specialized.
    jasongrout committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    6c41ec0 View commit details
    Browse the repository at this point in the history
  4. Fix tracking of scroll position across toggling consoles.

    Now if we are tailing a log, it will continue tailing the log when we switch back.
    jasongrout committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    60b66ad View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    22b1302 View commit details
    Browse the repository at this point in the history
  6. Set up a system for log versions that enables notification and displa…

    …y tracking.
    
    This should fix the display issues we were seeing with notifications not being properly triggered.
    jasongrout committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    050080f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0dd9522 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f62efaf View commit details
    Browse the repository at this point in the history
  9. Add todo

    jasongrout committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    0f436d4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5c6d18c View commit details
    Browse the repository at this point in the history
  11. Delete unnecessary todo

    jasongrout committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    d52227d View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2019

  1. Carefully account for message display to fix bugs and remove unnecess…

    …ary code.
    
    There are some subtle issues fixed here.
    
    1. LogConsolePanel is now more careful and complete in emitting sourceDisplayed signal so that we don’t have to have a message hook anymore.
    
    2. Because we more carefully account for displayed messages, we remove the flashEnabled checks in the status bar updates, which makes the flashing work more correctly. For example, with flashing enabled, now we will see the indicator flash when the console is open but not visible (for example, it may be hidden behind another tab).
    jasongrout committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    3fb09a5 View commit details
    Browse the repository at this point in the history
  2. Reorder code to follow JLab guidelines

    * reorder class methods/attributes to public/protected/private
    * alphabetically sort imports and some other lists of attributes
    jasongrout committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    9bde66c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7dbf2cc View commit details
    Browse the repository at this point in the history
  4. Integrity fix

    jasongrout committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    5c27453 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2019

  1. Fix log console tab icon

    jasongrout committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    f34ca0d View commit details
    Browse the repository at this point in the history
  2. Remove notebook output logging.

    Notebook output logging made it easier to test the logging console extension. I think it is too much noise for production, though, unless it is behind a option and turned off by default. See jupyterlab#7386
    jasongrout committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    0d4115d View commit details
    Browse the repository at this point in the history