-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up log console api a bit #7379
Commits on Oct 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 9bc63f1 - Browse repository at this point
Copy the full SHA 9bc63f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for da0e950 - Browse repository at this point
Copy the full SHA da0e950View commit details
Commits on Oct 17, 2019
-
Change toolbar buttons to command buttons so they can be disabled eas…
…ily. This also lets us set up keyboard shortcuts for the buttons, etc.
Configuration menu - View commit details
-
Copy full SHA for 38db0bc - Browse repository at this point
Copy the full SHA 38db0bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2afb2ae - Browse repository at this point
Copy the full SHA 2afb2aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 177f20f - Browse repository at this point
Copy the full SHA 177f20fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6532dfa - Browse repository at this point
Copy the full SHA 6532dfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04e60cc - Browse repository at this point
Copy the full SHA 04e60ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8c20a5 - Browse repository at this point
Copy the full SHA c8c20a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6e9e79 - Browse repository at this point
Copy the full SHA d6e9e79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 341782f - Browse repository at this point
Copy the full SHA 341782fView commit details -
Configuration menu - View commit details
-
Copy full SHA for db23c4d - Browse repository at this point
Copy the full SHA db23c4dView commit details -
Push the max log size down to the model
We also threaded the limit through the constructors so that the extension has sole control over the limit.
Configuration menu - View commit details
-
Copy full SHA for 2da6a4b - Browse repository at this point
Copy the full SHA 2da6a4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2105a18 - Browse repository at this point
Copy the full SHA 2105a18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75f66d1 - Browse repository at this point
Copy the full SHA 75f66d1View commit details
Commits on Oct 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 6aa7beb - Browse repository at this point
Copy the full SHA 6aa7bebView commit details -
Change log console highlight to use brand color.
The info color does not match well with the hardcoded status bar colors, especially in dark mode.
Configuration menu - View commit details
-
Copy full SHA for 8fd895e - Browse repository at this point
Copy the full SHA 8fd895eView commit details -
Track whether a log has ever had a message, and hide the status bar w…
…idget for inactive logs.
Configuration menu - View commit details
-
Copy full SHA for 540c4c0 - Browse repository at this point
Copy the full SHA 540c4c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6188897 - Browse repository at this point
Copy the full SHA 6188897View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8ddaec - Browse repository at this point
Copy the full SHA f8ddaecView commit details -
Use the new icon system for log console.
This allows the log console icons to look nice in all themes.
Configuration menu - View commit details
-
Copy full SHA for abe11d0 - Browse repository at this point
Copy the full SHA abe11d0View commit details -
Add a log console plugin to log all notebook outputs.
This is for testing purposes. It probably should be reverted later as logging all notebook outputs is rather noisy in the log.
Configuration menu - View commit details
-
Copy full SHA for 4407953 - Browse repository at this point
Copy the full SHA 4407953View commit details -
Exploration for how to communicate to the right components that curre…
…nt messages have been displayed.
Configuration menu - View commit details
-
Copy full SHA for fbfd865 - Browse repository at this point
Copy the full SHA fbfd865View commit details -
Revert "Exploration for how to communicate to the right components th…
…at current messages have been displayed." This reverts commit fbfd865.
Configuration menu - View commit details
-
Copy full SHA for da58234 - Browse repository at this point
Copy the full SHA da58234View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3638e3c - Browse repository at this point
Copy the full SHA 3638e3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e2bd8d7 - Browse repository at this point
Copy the full SHA e2bd8d7View commit details
Commits on Oct 19, 2019
-
It works great when you manually adjust the heights of the widgets as they are laid out. Once we figure out how to get the scrolling widget to have the appropriate height, I think this is good to go!
Configuration menu - View commit details
-
Copy full SHA for 60cf63d - Browse repository at this point
Copy the full SHA 60cf63dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0fc42b - Browse repository at this point
Copy the full SHA a0fc42bView commit details -
Move the scrolling widget back to the LogConsolePanel.
We have two basic approaches - we can have the scrolling behavior at the MainAreaWidget level (one intersection observer for the entire log console, but harder api since there is another wrapper around the content), or the scrolling behavior at the output area level (inside log console, which means an intersection observer for each output area, but simpler top-level api). I’m opting for the latter, and a bonus is that perhaps the scroll position can be preserved across different logs. We could also make a new main area widget with the scrolling behavior, but that seems a bit too specialized.
Configuration menu - View commit details
-
Copy full SHA for 6c41ec0 - Browse repository at this point
Copy the full SHA 6c41ec0View commit details -
Fix tracking of scroll position across toggling consoles.
Now if we are tailing a log, it will continue tailing the log when we switch back.
Configuration menu - View commit details
-
Copy full SHA for 60b66ad - Browse repository at this point
Copy the full SHA 60b66adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 22b1302 - Browse repository at this point
Copy the full SHA 22b1302View commit details -
Set up a system for log versions that enables notification and displa…
…y tracking. This should fix the display issues we were seeing with notifications not being properly triggered.
Configuration menu - View commit details
-
Copy full SHA for 050080f - Browse repository at this point
Copy the full SHA 050080fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dd9522 - Browse repository at this point
Copy the full SHA 0dd9522View commit details -
Configuration menu - View commit details
-
Copy full SHA for f62efaf - Browse repository at this point
Copy the full SHA f62efafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f436d4 - Browse repository at this point
Copy the full SHA 0f436d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c6d18c - Browse repository at this point
Copy the full SHA 5c6d18cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d52227d - Browse repository at this point
Copy the full SHA d52227dView commit details
Commits on Oct 20, 2019
-
Carefully account for message display to fix bugs and remove unnecess…
…ary code. There are some subtle issues fixed here. 1. LogConsolePanel is now more careful and complete in emitting sourceDisplayed signal so that we don’t have to have a message hook anymore. 2. Because we more carefully account for displayed messages, we remove the flashEnabled checks in the status bar updates, which makes the flashing work more correctly. For example, with flashing enabled, now we will see the indicator flash when the console is open but not visible (for example, it may be hidden behind another tab).
Configuration menu - View commit details
-
Copy full SHA for 3fb09a5 - Browse repository at this point
Copy the full SHA 3fb09a5View commit details -
Reorder code to follow JLab guidelines
* reorder class methods/attributes to public/protected/private * alphabetically sort imports and some other lists of attributes
Configuration menu - View commit details
-
Copy full SHA for 9bde66c - Browse repository at this point
Copy the full SHA 9bde66cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dbf2cc - Browse repository at this point
Copy the full SHA 7dbf2ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c27453 - Browse repository at this point
Copy the full SHA 5c27453View commit details
Commits on Oct 22, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f34ca0d - Browse repository at this point
Copy the full SHA f34ca0dView commit details -
Remove notebook output logging.
Notebook output logging made it easier to test the logging console extension. I think it is too much noise for production, though, unless it is behind a option and turned off by default. See jupyterlab#7386
Configuration menu - View commit details
-
Copy full SHA for 0d4115d - Browse repository at this point
Copy the full SHA 0d4115dView commit details