Added a shortcut to go to the last run or current running cell

[mlucool]

Code changes

Add a new action and shortcut. By default this shortcut has no hotkeys. I have found that Alt L was the best available option.

User-facing changes

User can add a new hotkey in the settings editor to enable this. The notebook must have execution time toggled on.

[jupyterlab-dev-mode]

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link:

[vidartf]

Thanks! Looks good, but two minor points to consider.

[vidartf]

Nitpick: Could these two lines be replaced by execution['iopub.status.busy'] !== undefined ?

[mlucool]

This was done. I will note that I had to cast it to a JSONObject before which is slightly less safe. If execution was set to 3 this will now throw.

[vidartf]

Good point. I think that using @phosphor/coreutils/JSONExt.isObject() will likely be the most robust method here (both in JS and for typings).

For reference, typeof null === 'object' 😕

[vidartf]

(Note: I'm not implying that the previous code was wrong, just that typeof X === 'object' is so counter-intuitive most of the time that I've made it a rule of thumb to simply avoid it)

[mlucool]

Fixed this anyway. Sadly, isObject fails to return a falsy value with JSONExt.isObject(undefined)

[mlucool]

@vidartf all issues have been addressed

[vidartf]

@mlucool I added another comment above. Kind of nit-picky, so feel free to ignore. Will merge once I've had a look at the CI failures.

[telamonian]

The Integrity CI is failing cuz of a failed lint check:

++ jlpm run lint:check
yarn run v1.15.2
$ jlpm run prettier:check && jlpm run eslint:check && jlpm run tslint:check
$ prettier --list-different '**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}'
packages/notebook-extension/src/index.ts
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
++ echo 'Please run `jlpm run lint` locally and push changes'
++ exit 1
Please run `jlpm run lint` locally and push changes

@mlucool Did you disable the normal jlab lint-on-commit/push git hooks? I know they give some devs trouble. In any case, you can prob fix the issue by doing what the error says and running:

jlpm run lint

in your repo before commiting/pushing again.