New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for a global track timing setting #7578
Conversation
This allows for a global default of whether or not to record timing metadata into the notebook metadata.
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
cc @Madhu94 A few comments:
I tired to inject this into the notebook metadata on creation at some point as well, but metadata is cleared after the notebook widget is assigned the model. |
Hey @mlucool thank you for implementing this. We (@tgeorgeux, @jasongrout, @ellisonbg) had a discussion about this feature and decided that it might be simpler to just remove the notebook level metadata and just use the global setting, defaulting to off. If it is off and there is existing execution time, then it should delete the |
@mlucool Lemme know if you want me to tackle this change. |
Thanks @saulshanabrook for looking. Sure, you can remove the notebook level feature. |
I removed the feature, originally added in #6864 |
I tried this locally and it seems to work. @afshin took a look at it and didn't have any objections. |
Code changes
This allows for a global default of whether or not to record timing metadata into the notebook file or not.
User-facing changes
A notebook setting was added to allow user to opt into this change.
Backwards-incompatible changes
None.