New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Lumino #7582
Merged
Merged
Use Lumino #7582
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
202892c
Update imports
86c7189
Alias phosphor packages to lumino packages
f36a2f1
update links
7312841
Update docs
a690991
Update mock package for test
aa3d4bf
Update test deps
6f4bc4f
more test import changes
8b9fab6
more renaming
c897c0c
update testutils
7488ed7
update buildutils
831fa99
update examples
68e0762
Update yarn.lock
ec720ff
Update yarn.lock
1052578
address review
a642f9a
lint
0c9a6fb
Remove phosphor shims
eabee65
Update datagrid usage and fix more imports
2ad4edf
Add mouse, key, and selection handling
1559d75
Update test
24cbfb5
more remaps
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -154,6 +154,67 @@ module.exports = [ | |
entry: { | ||
main: ['whatwg-fetch', plib.resolve(buildDir, 'index.out.js')] | ||
}, | ||
// Map Phosphor files to lumino files. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
resolve: { | ||
alias: { | ||
'@phosphor/algorithm$': plib.resolve( | ||
__dirname, | ||
'node_modules/@lumino/algorithm/lib/index.js' | ||
), | ||
'@phosphor/application$': plib.resolve( | ||
__dirname, | ||
'node_modules/@lumino/application/lib/index.js' | ||
), | ||
'@phosphor/commands$': plib.resolve( | ||
__dirname, | ||
'node_modules/@lumino/commands/lib/index.js' | ||
), | ||
'@phosphor/coreutils$': plib.resolve( | ||
__dirname, | ||
'node_modules/@lumino/coreutils/lib/index.js' | ||
), | ||
'@phosphor/disposable$': plib.resolve( | ||
__dirname, | ||
'node_modules/@lumino/disposable/lib/index.js' | ||
), | ||
'@phosphor/domutils$': plib.resolve( | ||
__dirname, | ||
'node_modules/@lumino/domutils/lib/index.js' | ||
), | ||
'@phosphor/dragdrop$': plib.resolve( | ||
__dirname, | ||
'node_modules/@lumino/dragdrop/lib/index.js' | ||
), | ||
'@phosphor/dragdrop/style': plib.resolve( | ||
__dirname, | ||
'node_modules/@lumino/widgets/style' | ||
), | ||
'@phosphor/messaging$': plib.resolve( | ||
__dirname, | ||
'node_modules/@lumino/messaging/lib/index.js' | ||
), | ||
'@phosphor/properties$': plib.resolve( | ||
__dirname, | ||
'node_modules/@lumino/properties/lib' | ||
), | ||
'@phosphor/signaling': plib.resolve( | ||
__dirname, | ||
'node_modules/@lumino/signaling/lib/index.js' | ||
), | ||
'@phosphor/widgets/style': plib.resolve( | ||
__dirname, | ||
'node_modules/@lumino/widgets/style' | ||
), | ||
'@phosphor/virtualdom$': plib.resolve( | ||
__dirname, | ||
'node_modules/@lumino/virtualdom/lib/index.js' | ||
), | ||
'@phosphor/widgets$': plib.resolve( | ||
__dirname, | ||
'node_modules/@lumino/widgets/lib/index.js' | ||
) | ||
} | ||
}, | ||
output: { | ||
path: plib.resolve(buildDir), | ||
publicPath: '{{page_config.fullStaticUrl}}/', | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have two options here?
--no-phosphor
as a legacy and--no-lumino
as the new option?