Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict nulls for everything except logconsole #7657

Merged
merged 16 commits into from Dec 23, 2019
Merged

Strict nulls for everything except logconsole #7657

merged 16 commits into from Dec 23, 2019

Commits on Dec 20, 2019

  1. Fix lint commands for windows

    @vidartf
    vidartf committed Dec 20, 2019
    Copy the full SHA
    0bdce26 View commit details
    Browse the repository at this point in the history

  2. Update to lumino/commands 1.9

    @vidartf
    vidartf committed Dec 20, 2019
    Copy the full SHA
    479815c View commit details
    Browse the repository at this point in the history

  3. Turn on strict null checks (except for services)

    @vidartf
    vidartf committed Dec 20, 2019
    Copy the full SHA
    df0b0f7 View commit details
    Browse the repository at this point in the history

  4. Add generic arg to IChangeArgs helper

    @vidartf
    vidartf committed Dec 20, 2019
    Copy the full SHA
    98e2a16 View commit details
    Browse the repository at this point in the history

  5. Simple typings changes for strict nulls 

    Should not require detailed review.
    @vidartf
    vidartf committed Dec 20, 2019
    Copy the full SHA
    db21fd2 View commit details
    Browse the repository at this point in the history

  6. Might supress wanted errors 

    These should not change the logic when operating normally, but might end up silently supressing failures instead of throwing errors in certain failure cases. On the other hand, the suppression might be what we want here.
    @vidartf
    vidartf committed Dec 20, 2019
    Copy the full SHA
    a9efefe View commit details
    Browse the repository at this point in the history

  7. non-null asserts 

    Some of these are likely not correct, some of them are. Hard to tell, but they are unlikely to affect the public API, so punting.
    @vidartf
    vidartf committed Dec 20, 2019
    Copy the full SHA
    f5019d8 View commit details
    Browse the repository at this point in the history

  8. Vdom always has model

    @vidartf
    vidartf committed Dec 20, 2019
    Copy the full SHA
    51f9943 View commit details
    Browse the repository at this point in the history

  9. dispose

    @vidartf
    vidartf committed Dec 20, 2019
    Copy the full SHA
    fed1b82 View commit details
    Browse the repository at this point in the history

  10. Logic changes 

    These made sense to me, but might be the wrong fixes!
    @vidartf
    vidartf committed Dec 20, 2019
    Copy the full SHA
    4569342 View commit details
    Browse the repository at this point in the history

  11. More partial types

    @vidartf
    vidartf committed Dec 20, 2019
    Copy the full SHA
    56bbec9 View commit details
    Browse the repository at this point in the history

  12. misc uncertainties

    @vidartf
    vidartf committed Dec 20, 2019
    Copy the full SHA
    cf623f1 View commit details
    Browse the repository at this point in the history

  13. Strict nulls for services

    @vidartf
    vidartf committed Dec 20, 2019
    Copy the full SHA
    e84817e View commit details
    Browse the repository at this point in the history

  14. integrity

    @vidartf
    vidartf committed Dec 20, 2019
    Copy the full SHA
    d5995b2 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2019

  1. Fixes for default value of session clientId

    @vidartf
    vidartf committed Dec 21, 2019
    Copy the full SHA
    3238bf4 View commit details
    Browse the repository at this point in the history

  2. Clean up some tests

    @vidartf
    vidartf committed Dec 21, 2019
    Copy the full SHA
    1b3930d View commit details
    Browse the repository at this point in the history