New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Property Inspector #7665
Add a Property Inspector #7665
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
75d88d9
to
78da7d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for the API changes - we can take up the UX issues in another PR after the beta. This does need a rebase before merging, though.
78da7d3
to
2e25330
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge and iterate on after these changes.
integrity finish property inspector lint integrity Strict null handling unused import Address review comments
d7737d6
to
708944a
Compare
References
Fixes #7664
Code changes
Adds a
property-inspector
package and default implementation of the extension inapplication-extension
. The notebook extension is updated to use the inspector.User-facing changes
If no other extensions are installed that use the side panel, the use will always see the tool icon even when no notebooks are open, with the text "No properties to inspect.".
I attempted to only show the tab when one or more inspectors are registered, but it conflicts with our logic that allows side bar items to be moved to the opposite side.
Backwards-incompatible changes
None.