Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework services terminal code #7674

Merged
merged 18 commits into from Dec 23, 2019
Merged

Rework services terminal code #7674

merged 18 commits into from Dec 23, 2019

Commits on Dec 20, 2019

  1. WIP Rework terminal to follow the conventions and design of kernels a… 

    …nd sessions
    @jasongrout
    jasongrout committed Dec 20, 2019
    Copy the full SHA
    57d0d37 View commit details
    Browse the repository at this point in the history

  2. Bind the appropriate this context for a setTimeout callback in kern… 

    …el reconnect attempts.
    @jasongrout
    jasongrout committed Dec 20, 2019
    Copy the full SHA
    fe99f3e View commit details
    Browse the repository at this point in the history

  3. Simplify connection status update logic.

    @jasongrout
    jasongrout committed Dec 20, 2019
    Copy the full SHA
    1954589 View commit details
    Browse the repository at this point in the history

  4. Tweak kernel tests to be more correct and complete.

    @jasongrout
    jasongrout committed Dec 20, 2019
    Copy the full SHA
    5033611 View commit details
    Browse the repository at this point in the history

  5. Initial pass on reworking the services terminal code to be consistent… 

    … with the kernel code.
    @jasongrout
    jasongrout committed Dec 20, 2019
    Copy the full SHA
    0211399 View commit details
    Browse the repository at this point in the history

  6. Fix compile errors and behavior when shutting down a terminal.

    @jasongrout
    jasongrout committed Dec 20, 2019
    Copy the full SHA
    74f667d View commit details
    Browse the repository at this point in the history

  7. Delete obsolete commented code

    @jasongrout
    jasongrout committed Dec 20, 2019
    Copy the full SHA
    838903c View commit details
    Browse the repository at this point in the history

  8. Bind a setTimeout callback properly to this

    @jasongrout
    jasongrout committed Dec 20, 2019
    Copy the full SHA
    59a3931 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2019

  1. A catch function *must* have an empty function to properly catch errors.

    @jasongrout
    jasongrout committed Dec 21, 2019
    Copy the full SHA
    59f562e View commit details
    Browse the repository at this point in the history

  2. Fix dispose logic errors in kernels and sessions.

    @jasongrout
    jasongrout committed Dec 21, 2019
    Copy the full SHA
    44a62a4 View commit details
    Browse the repository at this point in the history

  3. Fix terminal tests, and issues exposed by the tests.

    @jasongrout
    jasongrout committed Dec 21, 2019
    Copy the full SHA
    49a7918 View commit details
    Browse the repository at this point in the history

  4. Fix reconnect test. 

    Turns out that the _createSocket command is already bound to `this`, so we don’t need to wrap it in an arrow function.
    @jasongrout
    jasongrout committed Dec 21, 2019
    Copy the full SHA
    3cf7234 View commit details
    Browse the repository at this point in the history

  5. Fix examples

    @jasongrout
    jasongrout committed Dec 21, 2019
    Copy the full SHA
    98d86e2 View commit details
    Browse the repository at this point in the history

  6. Fix compile error

    @jasongrout
    jasongrout committed Dec 21, 2019
    Copy the full SHA
    cf6e3e9 View commit details
    Browse the repository at this point in the history

  7. Fix terminal tests.

    @jasongrout
    jasongrout committed Dec 21, 2019
    Copy the full SHA
    e18846e View commit details
    Browse the repository at this point in the history

  8. Send a terminal stdin message to make sure to get output.

    @jasongrout
    jasongrout committed Dec 21, 2019
    Copy the full SHA
    dbba8a7 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2019

  1. Merge remote-tracking branch 'origin/master' into terminalrework

    @jasongrout
    jasongrout committed Dec 23, 2019
    Copy the full SHA
    3c146c1 View commit details
    Browse the repository at this point in the history

  2. Fix null check error

    @jasongrout
    jasongrout committed Dec 23, 2019
    Copy the full SHA
    b7d2948 View commit details
    Browse the repository at this point in the history